tree-wide: always explicitly pass check to subprocess.run
pylint recently started recommending this.
This commit is contained in:
parent
ff8b21ae22
commit
cd59b94ded
5 changed files with 22 additions and 17 deletions
|
|
@ -67,6 +67,9 @@ class BuildRoot:
|
|||
Its arguments mean the same as those for subprocess.run().
|
||||
"""
|
||||
|
||||
# pylint suggests to epxlicitly pass `check` to subprocess.run()
|
||||
check = kwargs.pop("check", False)
|
||||
|
||||
return subprocess.run([
|
||||
"systemd-nspawn",
|
||||
"--quiet",
|
||||
|
|
@ -77,7 +80,7 @@ class BuildRoot:
|
|||
f"--directory={self.root}",
|
||||
*[f"--bind={b}" for b in (binds or [])],
|
||||
*[f"--bind-ro={b}" for b in [f"{self.api}:/run/osbuild/api"] + (readonly_binds or [])],
|
||||
] + argv, **kwargs)
|
||||
] + argv, check=check, **kwargs)
|
||||
|
||||
@contextlib.contextmanager
|
||||
def bound_socket(self, name):
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue