From f892351b003fef610cc781ddfd79df383686416b Mon Sep 17 00:00:00 2001 From: Michael Vogt Date: Thu, 4 Apr 2024 15:05:32 +0200 Subject: [PATCH] tools: tweak depsolve() helper to show stderr from depsolve So that we see any error output during the tests in "realtime". With subprocess check=True and capture_output=True on exit_code != 0 no stderr as part of the exception by default so this change helps seeing issues from depsolve-dnf more easily. --- tools/test/test_depsolve.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/test/test_depsolve.py b/tools/test/test_depsolve.py index d32c71a5..cf282bc9 100644 --- a/tools/test/test_depsolve.py +++ b/tools/test/test_depsolve.py @@ -5,6 +5,7 @@ import os import pathlib import socket import subprocess as sp +import sys from tempfile import TemporaryDirectory import pytest @@ -41,9 +42,7 @@ def depsolve(pkgs, repos, root_dir, cache_dir, command): ] } } - p = sp.run([command], input=json.dumps(req).encode(), check=True, capture_output=True) - if p.stderr: - print(p.stderr.decode()) + p = sp.run([command], input=json.dumps(req).encode(), check=True, stdout=sp.PIPE, stderr=sys.stderr) return json.loads(p.stdout.decode())