From fe05b3084bcd87f0085d8141401d54ddf4df97dc Mon Sep 17 00:00:00 2001 From: Michael Vogt Date: Tue, 2 Apr 2024 15:30:04 +0200 Subject: [PATCH] sources: add regression test for issue##1693 There was a regression with the secrets adding of rhsm for the curl source. This was my mistake (sorry!). Here is a regression test that would have prevented this (if we have had it earlier). --- sources/test/test_curl_source.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/sources/test/test_curl_source.py b/sources/test/test_curl_source.py index 4d2dd7d1..1dae9e0f 100644 --- a/sources/test/test_curl_source.py +++ b/sources/test/test_curl_source.py @@ -71,3 +71,22 @@ def test_curl_source_amend_secrets_fail(sources_service): with pytest.raises(RuntimeError) as exc: sources_service.amend_secrets(checksum, desc) assert "mtls secrets required" in str(exc) + + +class FakeSubscriptionManager: + def get_secrets(self, url): + return f"secret-for-{url}" + + +def test_curl_source_amend_secrets_subscription_mgr(sources_service): + desc = { + "url": "http://localhost:80/a", + "secrets": { + "name": "org.osbuild.rhsm", + }, + } + + sources_service.subscriptions = FakeSubscriptionManager() + checksum = "sha256:1234567890123456789012345678901234567890909b14ffb032aa20fa23d9ad6" + checksum, desc = sources_service.amend_secrets(checksum, desc) + assert desc["secrets"] == "secret-for-http://localhost:80/a"