debian-forge/osbuild/util/containers.py
Tomáš Hozza a50795b627 osbuild/util/containers.py: disable pylint issue W0135
Disable the newly reported pylint issue W0135
(contextmanager-generator-missing-cleanup), because as far as I was able
to understand the motivation behind it, it should not apply to the code
and it should be a false positive. We do not use context manager inside
a generator, but inside another context manager. So the execution flow
should return sequentially through the stack and all context manager
cleanups should be executed as expected.

The reported issue:
osbuild/util/containers.py:184:4: W0135: The context used in function 'container_source' will not be exited. (contextmanager-generator-missing-cleanup)

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2024-11-25 10:09:18 +01:00

186 lines
7.8 KiB
Python

import json
import os
import subprocess
import tempfile
from contextlib import contextmanager
from osbuild.util.mnt import MountGuard, MountPermissions
def is_manifest_list(data):
"""Inspect a manifest determine if it's a multi-image manifest-list."""
media_type = data.get("mediaType")
# Check if mediaType is set according to docker or oci specifications
if media_type in ("application/vnd.docker.distribution.manifest.list.v2+json",
"application/vnd.oci.image.index.v1+json"):
return True
# According to the OCI spec, setting mediaType is not mandatory. So, if it is not set at all, check for the
# existence of manifests
if media_type is None and data.get("manifests") is not None:
return True
return False
def parse_manifest_list(manifests):
"""Return a map with single-image manifest digests as keys and the manifest-list digest as the value for each"""
manifest_files = manifests["data"]["files"]
manifest_map = {}
for fname in manifest_files:
filepath = os.path.join(manifests["path"], fname)
with open(filepath, mode="r", encoding="utf-8") as mfile:
data = json.load(mfile)
for manifest in data["manifests"]:
digest = manifest["digest"] # single image manifest digest
manifest_map[digest] = fname
return manifest_map
def manifest_digest(path):
"""Get the manifest digest for a container at path, stored in dir: format"""
return subprocess.check_output(["skopeo", "manifest-digest", os.path.join(path, "manifest.json")]).decode().strip()
def parse_containers_input(inputs):
manifests = inputs.get("manifest-lists")
manifest_map = {}
manifest_files = {}
if manifests:
manifest_files = manifests["data"]["files"]
# reverse map manifest-digest -> manifest-list path
manifest_map = parse_manifest_list(manifests)
images = inputs["images"]
archives = images["data"]["archives"]
res = {}
for checksum, data in archives.items():
filepath = os.path.join(images["path"], checksum)
list_path = None
if data["format"] == "dir":
digest = manifest_digest(filepath)
# get the manifest list path for this image
list_digest = manifest_map.get(digest)
if list_digest:
# make sure all manifest files are used
del manifest_files[list_digest]
list_path = os.path.join(manifests["path"], list_digest)
if data["format"] == "containers-storage":
# filepath is the storage bindmount
filepath = os.path.join(images["path"], "storage")
res[checksum] = {
"filepath": filepath,
"manifest-list": list_path,
"data": data,
"checksum": checksum, # include the checksum in the value
}
if manifest_files:
raise RuntimeError(
"The following manifest lists specified in the input did not match any of the container images: " +
", ".join(manifest_files)
)
return res
def merge_manifest(list_manifest, destination):
"""
Merge the list manifest into the image directory. This preserves the manifest list with the image in the registry so
that users can run or inspect a container using the original manifest list digest used to pull the container.
See https://github.com/containers/skopeo/issues/1935
"""
# calculate the checksum of the manifest of the container image in the destination
dest_manifest = os.path.join(destination, "manifest.json")
manifest_checksum = subprocess.check_output(["skopeo", "manifest-digest", dest_manifest]).decode().strip()
parts = manifest_checksum.split(":")
assert len(parts) == 2, f"unexpected output for skopeo manifest-digest: {manifest_checksum}"
manifest_checksum = parts[1]
# rename the manifest to its checksum
os.rename(dest_manifest, os.path.join(destination, manifest_checksum + ".manifest.json"))
# copy the index manifest into the destination
subprocess.run(["cp", "--reflink=auto", "-a", list_manifest, dest_manifest], check=True)
@contextmanager
def containers_storage_source(image, image_filepath, container_format):
storage_conf = image["data"]["storage"]
driver = storage_conf.get("driver", "overlay")
# use `/run/osbuild/containers/storage` for the containers-storage bind mount
# since this ostree-compatible and the stage that uses this will be run
# inside a ostree-based build-root in `bootc-image-builder`
storage_path = os.path.join(os.sep, "run", "osbuild", "containers", "storage")
os.makedirs(storage_path, exist_ok=True)
with MountGuard() as mg:
mg.mount(image_filepath, storage_path, permissions=MountPermissions.READ_WRITE)
# NOTE: the ostree.deploy.container needs explicit `rw` access to
# the containers-storage store even when bind mounted. Remounting
# the bind mount is a pretty dirty fix to get us up and running with
# containers-storage in `bootc-image-builder`. We could maybe check
# if we're inside a bib-continaer and only run this conidtionally.
mg.mount(image_filepath, storage_path, remount=True, permissions=MountPermissions.READ_WRITE)
image_id = image["checksum"].split(":")[1]
image_source = f"{container_format}:[{driver}@{storage_path}+/run/containers/storage]{image_id}"
yield image_source
if driver == "overlay":
# NOTE: the overlay sub-directory isn't always released,
# so we need to force unmount it
ret = subprocess.run(["umount", "-f", "--lazy", os.path.join(storage_path, "overlay")], check=False)
if ret.returncode != 0:
print(f"WARNING: umount of overlay dir failed with an error: {ret}")
@contextmanager
def dir_oci_archive_source(image, image_filepath, container_format):
with tempfile.TemporaryDirectory() as tmpdir:
tmp_source = os.path.join(tmpdir, "image")
if container_format == "dir" and image["manifest-list"]:
# copy the source container to the tmp source so we can merge the manifest into it
subprocess.run(["cp", "-a", "--reflink=auto", image_filepath, tmp_source], check=True)
merge_manifest(image["manifest-list"], tmp_source)
else:
# We can't have special characters like ":" in the source names because containers/image
# treats them special, like e.g. /some/path:tag, so we make a symlink to the real name
# and pass the symlink name to skopeo to make it work with anything
os.symlink(image_filepath, tmp_source)
image_source = f"{container_format}:{tmp_source}"
yield image_source
@contextmanager
def container_source(image):
image_filepath = image["filepath"]
container_format = image["data"]["format"]
image_name = image["data"]["name"]
if container_format not in ("dir", "oci-archive", "containers-storage"):
raise RuntimeError(f"Unknown container format {container_format}")
if container_format == "containers-storage":
container_source_fn = containers_storage_source
elif container_format in ("dir", "oci-archive"):
container_source_fn = dir_oci_archive_source
else:
raise RuntimeError(f"Unknown container format {container_format}")
# pylint: disable=contextmanager-generator-missing-cleanup
# thozza: As far as I can tell, the problematic use case is when the ctx manager is used inside a generator.
# However, this is not the case here. The ctx manager is used inside another ctx manager with the expectation
# that the inner ctx manager won't be cleaned up until the execution returns to this ctx manager.
with container_source_fn(image, image_filepath, container_format) as image_source:
yield image_name, image_source