This commit extract a helper `get_parent_path()` that is unit tested and also uses this generated parent_path for the call to manage_devices_file to be consistent with the exiting behavior of only including the device that actually contains the VG.
249 lines
7.1 KiB
Python
Executable file
249 lines
7.1 KiB
Python
Executable file
#!/usr/bin/python3
|
|
"""
|
|
Host service for providing access to LVM2 logical volumes
|
|
|
|
This host service can be used to activate logical volumes
|
|
so that they can be accessed from osbuild stages.
|
|
The parent volume group is identified via the physical
|
|
device which must be passed to this service as parent.
|
|
|
|
Example usage, where `lvm` here is the lvm partition and
|
|
`root` then the logical volume named `root`:
|
|
```
|
|
"lvm": {
|
|
"type": "org.osbuild.loopback",
|
|
"options": {
|
|
"filename": "disk.img",
|
|
"start": ...,
|
|
},
|
|
"root": {
|
|
"type": "org.osbuild.lvm2.lv",
|
|
"parent": "lvm",
|
|
"options": {
|
|
"volume": "root"
|
|
}
|
|
}
|
|
```
|
|
|
|
Required host tools: lvchange, pvdisplay, lvdisplay
|
|
"""
|
|
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
import time
|
|
from typing import Dict, Tuple, Union
|
|
|
|
from osbuild import devices
|
|
|
|
SCHEMA = """
|
|
"additionalProperties": false,
|
|
"required": ["volume"],
|
|
"properties": {
|
|
"volume": {
|
|
"type": "string",
|
|
"description": "Logical volume to active"
|
|
},
|
|
"vg_partnum": {
|
|
"type": "number",
|
|
"description": "Partition number on the parent device where the LV's volume group is located"
|
|
}
|
|
}
|
|
"""
|
|
|
|
|
|
def get_parent_path(parent: str, options: Dict) -> str:
|
|
""" get_parent_path returns the full path to the block device for parent
|
|
|
|
Note that the options can influence the behavior via the vg partition
|
|
number option.
|
|
"""
|
|
assert not parent.startswith("/")
|
|
parent_path = os.path.join("/dev", parent)
|
|
part = options.get("vg_partnum")
|
|
if part:
|
|
parent_path += f"p{part}"
|
|
return parent_path
|
|
|
|
|
|
class LVService(devices.DeviceService):
|
|
|
|
def __init__(self, args):
|
|
super().__init__(args)
|
|
self.fullname = None
|
|
self.target = None
|
|
self.devices_file = None
|
|
|
|
def manage_devices_file(self, device: str):
|
|
# if LVM2 uses system.devices file, the LVM2 physical device we created
|
|
# inside the stage won't be seen since it wont be added to `system.devices`
|
|
# so we need to manage our own devices file
|
|
|
|
if not os.path.exists("/etc/lvm/devices/system.devices"):
|
|
return
|
|
|
|
self.devices_file = f"osbuild-{os.getpid()}.devices"
|
|
print(f"adding device to '{self.devices_file}'")
|
|
|
|
cmd = [
|
|
"lvmdevices",
|
|
"--adddev", device,
|
|
"--devicesfile", self.devices_file
|
|
]
|
|
|
|
res = subprocess.run(cmd,
|
|
check=False,
|
|
stdout=subprocess.DEVNULL,
|
|
stderr=subprocess.PIPE,
|
|
encoding="UTF-8")
|
|
|
|
if res.returncode != 0:
|
|
data = res.stderr.strip()
|
|
msg = f"Failed to add '{device}' to '{self.devices_file}': {data}"
|
|
raise RuntimeError(msg)
|
|
|
|
def lv_set_active(self, fullname: str, status: bool):
|
|
mode = "y" if status else "n"
|
|
cmd = [
|
|
"lvchange", "--activate", mode, fullname
|
|
]
|
|
|
|
if self.devices_file:
|
|
cmd += ["--devicesfile", self.devices_file]
|
|
|
|
res = subprocess.run(cmd,
|
|
check=False,
|
|
stdout=subprocess.DEVNULL,
|
|
stderr=subprocess.PIPE,
|
|
encoding="UTF-8")
|
|
|
|
if res.returncode != 0:
|
|
data = res.stderr.strip()
|
|
msg = f"Failed to set LV device ({fullname}) status: {data}"
|
|
raise RuntimeError(msg)
|
|
|
|
def volume_group_for_device(self, device: str) -> Union[int, str]:
|
|
# Find the volume group that belongs to the device specified via `parent`
|
|
vg_name = None
|
|
count = 0
|
|
|
|
cmd = [
|
|
"pvdisplay", "-C", "--noheadings", "-o", "vg_name", device
|
|
]
|
|
|
|
if self.devices_file:
|
|
cmd += ["--devicesfile", self.devices_file]
|
|
|
|
while True:
|
|
res = subprocess.run(cmd,
|
|
check=False,
|
|
stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
encoding="UTF-8")
|
|
|
|
if res.returncode == 5:
|
|
if count == 10:
|
|
raise RuntimeError("Could not find parent device")
|
|
time.sleep(1 * count)
|
|
count += 1
|
|
continue
|
|
|
|
if res.returncode != 0:
|
|
json.dump({"error": res.stderr.strip()}, sys.stdout)
|
|
return 1
|
|
|
|
vg_name = res.stdout.strip()
|
|
if vg_name:
|
|
break
|
|
|
|
return vg_name
|
|
|
|
def device_for_logical_volume(self, vg_name: str, volume: str) -> Tuple[int, int]:
|
|
# Now that we have the volume group, find the specified logical volume and its device path
|
|
|
|
cmd = [
|
|
"lvdisplay", "-C", "--noheadings",
|
|
"-o", "lv_kernel_major,lv_kernel_minor",
|
|
"--separator", ";",
|
|
"-S", f"lv_name={volume}",
|
|
vg_name
|
|
]
|
|
|
|
if self.devices_file:
|
|
cmd += ["--devicesfile", self.devices_file]
|
|
|
|
res = subprocess.run(cmd,
|
|
check=False,
|
|
stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
encoding="UTF-8")
|
|
|
|
if res.returncode != 0:
|
|
raise RuntimeError(res.stderr.strip())
|
|
|
|
data = res.stdout.strip()
|
|
devnum = list(map(int, data.split(";")))
|
|
assert len(devnum) == 2
|
|
major, minor = devnum[0], devnum[1]
|
|
|
|
return major, minor
|
|
|
|
def open(self, devpath: str, parent: str, tree: str, options: Dict) -> Dict:
|
|
lv = options["volume"]
|
|
|
|
parent_path = get_parent_path(parent, options)
|
|
|
|
# Add the device to a lvm devices file on supported systems
|
|
self.manage_devices_file(parent_path)
|
|
|
|
# Find the volume group that belongs to the device specified
|
|
# via `parent`
|
|
vg = self.volume_group_for_device(parent_path)
|
|
|
|
# Activate the logical volume
|
|
self.fullname = f"{vg}/{lv}"
|
|
self.lv_set_active(self.fullname, True)
|
|
|
|
# Now that we have the volume group, find the major and minor
|
|
# device numbers for the logical volume
|
|
major, minor = self.device_for_logical_volume(vg, lv) # type: ignore
|
|
|
|
# Create the device node for the LV in the build root's /dev
|
|
devname = os.path.join(vg, lv) # type: ignore
|
|
fullpath = os.path.join(devpath, devname)
|
|
|
|
os.makedirs(os.path.join(devpath, vg), exist_ok=True) # type: ignore
|
|
self.ensure_device_node(fullpath, major, minor)
|
|
|
|
data = {
|
|
"path": devname,
|
|
"node": {
|
|
"major": major,
|
|
"minor": minor
|
|
},
|
|
"lvm": {
|
|
"vg_name": vg,
|
|
"lv_name": lv
|
|
}
|
|
}
|
|
return data
|
|
|
|
def close(self):
|
|
if self.fullname:
|
|
self.lv_set_active(self.fullname, False)
|
|
self.fullname = None
|
|
|
|
if self.devices_file:
|
|
os.unlink(os.path.join("/etc/lvm/devices", self.devices_file))
|
|
self.devices_file = None
|
|
|
|
|
|
def main():
|
|
service = LVService.from_args(sys.argv[1:])
|
|
service.main()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
r = main()
|
|
sys.exit(r)
|