particle-os/debian-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
debian-forge/stages
History
Tomáš Hozza 3e780762cb stages/sgdisk: option to not quote partition names passed to sgdisk 
The partition name in the sgdisk stage was previously quoted when
passed to sgdisk as an argument. I think that this was done because
the sgdisk man page states that:

```
If you want to set a name that includes a space, enclose it in
quotation marks, as in sgdisk -c 1:"Sample Name" /dev/sdb.
```

However, this should apply only when sgdisk is run in a shell, so that
the argument is not split by shell into multiple arguments and passes
as a single string.

The stage is executing sgdisk using Python `subprocess` module, which
does not need strings with spaces to be quoted, because they are passed
to the command as separate items which are not split in any way.

The previous behavior of the stage was that these quotes became part of
the actual partition name in the partition table.

After a discussion within the team, we determined that this is a bug.
However, fixing it would result in osbuild producing a different
artifact for the same manifest, compared to osbuild version without such
fix. This is undesired.

For backward compatibility, a new `quote_partition_name` property is
added to the stage options, which can be used to make the stage not
quote the partition name when passed to `sgdisk`. As a result, the
partition name won't be quoted in the partition table.

The default stage behavior us kept.

Modify unit tests to use this option by default.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2023-05-26 08:43:52 +02:00
..
org.osbuild.anaconda osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.authconfig osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.authselect osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.bootiso.mono osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.buildstamp osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.chmod stages/chmod: SCHEMA_2 2021-07-01 10:49:38 +02:00
org.osbuild.chown Add org.osbuild.chown stage 2023-02-07 12:14:01 +01:00
org.osbuild.chrony osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.clevis.luks-bind osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.cloud-init osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.containers.storage.conf stages/containers.storage: ability to specify a base file 2022-11-15 11:34:15 +01:00
org.osbuild.copy stages/copy: add option to remove destination before copying 2023-02-20 10:31:06 +01:00
org.osbuild.cpio.out stages: add new cpio.out stage 2022-11-03 17:26:43 +01:00
org.osbuild.cron.script osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.crypttab osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.debug-shell osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.discinfo osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.dnf-automatic.config osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.dnf.config osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.dracut osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.dracut.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.error osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.fdo osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.firewall stages/firewall: change zones/sources handling 2022-10-26 12:07:21 +02:00
org.osbuild.first-boot osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.fix-bls osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.fstab osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.gcp.guest-agent.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.greenboot stages/greenboot: avoid new pylint suppressions 2022-09-14 12:26:37 +02:00
org.osbuild.groups osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.grub2 osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.grub2.inst osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.grub2.iso grub2.iso: add timeout option 2022-11-11 17:22:14 +01:00
org.osbuild.grub2.legacy osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.gunzip osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.gzip osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.hostname osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ignition stages/ignition: support multi kargs in network kcmdline 2023-02-27 17:39:14 +01:00
org.osbuild.implantisomd5 osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.isolinux stages/isolinux: default list 2023-05-23 10:13:15 +02:00
org.osbuild.kernel-cmdline osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.keymap stages/keymap: add font option 2022-10-25 11:20:11 +02:00
org.osbuild.kickstart osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.locale osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.lorax-script stages/lorax-script: add missing type of path to the schema 2023-04-19 12:42:27 +02:00
org.osbuild.luks2.format osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.luks2.remove-key osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.lvm2.create osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.lvm2.metadata stages/lvm2.metadata: fix typo in regex 2021-08-21 09:10:42 +02:00
org.osbuild.mkdir stages/mkdir: enhance stage documentation 2023-01-20 14:28:36 +01:00
org.osbuild.mkfs.btrfs osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.mkfs.ext4 org.osbuild.mkfs.ext4: Add verity option to 2023-05-16 00:03:16 +02:00
org.osbuild.mkfs.fat osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.mkfs.xfs osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.mkinitcpio Add mkinitcpio stage 2021-12-21 10:44:55 +01:00
org.osbuild.modprobe osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.nginx.conf modules: explicit encodings for open() 2022-09-09 15:33:29 +02:00
org.osbuild.nm.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.nm.conn osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.noop osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.oci-archive osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.oscap.remediation osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.commit osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.config ostree.config: add aboot (Android) bootloader config option 2022-12-15 11:27:02 +00:00
org.osbuild.ostree.deploy osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.encapsulate stages: add new org.osbuild.ostree.encapsulate 2022-12-15 11:13:19 +01:00
org.osbuild.ostree.fillvar osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.init osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.init-fs osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.os-init osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.passwd osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.preptree stages/ostree.preptree: fix broken link 2022-10-26 15:04:53 +02:00
org.osbuild.ostree.pull osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.remotes osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ostree.selinux osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.ovf stages/org.osbuild.ovf: support older python3 versions 2023-05-09 23:54:01 +02:00
org.osbuild.pacman osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.pacman-keyring stages: add pacman keyring stage 2022-03-01 16:07:27 +01:00
org.osbuild.pacman.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.pacman.mirrorlist.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.pam.limits.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.parted osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.pwquality.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.qemu osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.resolv-conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.rhsm osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.rhsm.facts stages/rhsm.facts: create facts file in /etc 2023-01-03 09:27:13 +01:00
org.osbuild.rpm stages/rpm: make the fake machine-id newline-terminated 2022-10-18 14:40:24 +02:00
org.osbuild.rpm-ostree osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.rpm.macros osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.rpmkeys.import osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.selinux osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.selinux.config osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.sfdisk stages/sfdisk: support changing GPT partition attribute bits 2023-05-25 14:57:28 +02:00
org.osbuild.sgdisk stages/sgdisk: option to not quote partition names passed to sgdisk 2023-05-26 08:43:52 +02:00
org.osbuild.shell.init stages/shell.init: add top-level files property 2023-02-15 18:14:01 +01:00
org.osbuild.skopeo stages/skopeo: merge manifest into image directory 2023-03-31 14:57:26 +02:00
org.osbuild.squashfs osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.sshd.config osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.sysconfig osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.sysctld osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.systemd osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.systemd-journald stages: add org.osbuild.systemd-journald stage 2022-10-21 09:04:51 +02:00
org.osbuild.systemd-logind stages/logind-systemd: add ReserveVT option 2022-10-22 14:58:44 +02:00
org.osbuild.systemd.preset stage/systemd.preset: be able to write a preset file 2023-04-05 14:34:39 +02:00
org.osbuild.systemd.unit osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.tar osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.test osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.timezone osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.tmpfilesd osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.truncate osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.tuned osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.udev.rules osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.uki stages: add stage to build unified kernel images 2022-11-14 20:10:59 +01:00
org.osbuild.untar osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.users stages/users: create missing home directories 2022-12-07 17:25:30 +01:00
org.osbuild.vagrant osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.waagent.conf osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.wsl.conf stages/org.osbuild.wsl.conf: add stage to configure WSL settings 2023-04-11 10:11:08 +02:00
org.osbuild.xorrisofs osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.xz osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.yum.config osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.yum.repos stages/yum.repo: add sslverify field 2023-05-03 20:53:52 +02:00
org.osbuild.zipl osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
org.osbuild.zipl.inst osbuild: run isort on all files 2022-09-12 13:32:51 +02:00