particle-os/debian-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
debian-forge/test/data
History
Tomáš Hozza 3e780762cb stages/sgdisk: option to not quote partition names passed to sgdisk 
The partition name in the sgdisk stage was previously quoted when
passed to sgdisk as an argument. I think that this was done because
the sgdisk man page states that:

```
If you want to set a name that includes a space, enclose it in
quotation marks, as in sgdisk -c 1:"Sample Name" /dev/sdb.
```

However, this should apply only when sgdisk is run in a shell, so that
the argument is not split by shell into multiple arguments and passes
as a single string.

The stage is executing sgdisk using Python `subprocess` module, which
does not need strings with spaces to be quoted, because they are passed
to the command as separate items which are not split in any way.

The previous behavior of the stage was that these quotes became part of
the actual partition name in the partition table.

After a discussion within the team, we determined that this is a bug.
However, fixing it would result in osbuild producing a different
artifact for the same manifest, compared to osbuild version without such
fix. This is undesired.

For backward compatibility, a new `quote_partition_name` property is
added to the stage options, which can be used to make the stage not
quote the partition name when passed to `sgdisk`. As a result, the
partition name won't be quoted in the partition table.

The default stage behavior us kept.

Modify unit tests to use this option by default.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2023-05-26 08:43:52 +02:00
..
manifests test/data: set source epoch for certain pipelines 2022-12-15 13:10:35 +00:00
os-release test: update test manifests to use Fedora 34 2021-06-07 12:15:26 +02:00
scripts osbuild: run isort on all files 2022-09-12 13:32:51 +02:00
sources sources/ostree: set contenturl when pulling from remote 2022-10-14 12:04:54 +02:00
stages stages/sgdisk: option to not quote partition names passed to sgdisk 2023-05-26 08:43:52 +02:00
README.md test: rename mpp-*.json to *.mpp.json 2020-10-19 17:37:46 +01:00
v2 test: Add skopeo tests 2022-02-10 14:43:17 +01:00

README.md

OSBuild Test Data

This directory contains data used by the osbuild test-suite. Since many formats do not allow comments, this file shortly describes their purpose.

Directories

  • ./os-release/: This directory is consumed by the unit-tests of the os-release parser. The directory contains example os-release files (see os-release(5)). Their directory name is the expected output of the parser.

  • ./manifests/: This directory contains osbuild manifests used throughout the test-suite.

    Manifests prefixed with f30, f31, etc. are manifests that produce fedora images. If they have base as part of their name, they include a base set of packages which we very loosely define as @core plus the packages our test-suite needs. If they have build as part of their name, they have a very restricted package set which includes just what is needed in a build-root for osbuild. The fedora prefix is used for manifests that are kept up to date to the newest fedora release, and thus do not expose a specific f30, f32, etc. behavior.

    The rhel prefix is used for Red Hat Enterprise Linux images. Since they are not available publicly, the test-suite usually skips them.

    The filesystem manifest is used to test assemblers. These tests doesn't need a big filesystem tree representing a whole operating system. Instead, this manifest's tree is constructed just from the filesystem package and is marked using the selinux stage.

    Manifests ending on .mpp.json are fed through the ManifestPreProcessors and then stored in the same directory with an .json extension (replacing .mpp.json). generated files are committed to the repository. Nevertheless, if you need to regenerate them, use make test-data.

  • ./sources/: This directory contains test-data for runtime tests of the source-engines. It contains a directory that is served via HTTP in the tests, and a directory of test-cases what to expect when using the attached sources.json.

  • scripts: This directory contains scripts used from other tests, i.e. although they are executables they are at the same time test-data to the actual (unit) tests.