Introduce a new class `SpdxLicenseExpressionCreator`, responsible for converting license texts extracted from packages, into an SPDX-compliant license expressions. If the `license_expression` Python package is available on the system, it is used to determine the license text extracted from a package is a valid SPDX license expression. If it is, it's returned as is back to the caller. If it is not, or of the package is not available on the system, the license text is wrapped in a `ExtractedLicensingInfo` instance. The `SpdxLicenseExpressionCreator` object keeps track of all generated `ExtractedLicensingInfo` instances and de-duplicates them based on the license text. This means that if two packages use the same SPDX-non-compliant license text, they will be wrapped by an `ExtractedLicensingInfo` instance with the same `LicenseRef-` ID. The reason for fallback when `license_expression` package is not available is that it is not available on RHEL and CentOS Stream. This implementation allows us to ship the functionality in RHEL and optionally enabling it by installing `license_expression` from a 3rd party repository. In any case, the generated SBOM document will always contain valid SPDX license expressions. Extend unit tests to cover the newly added functionality. Signed-off-by: Tomáš Hozza <thozza@redhat.com> FIXUP: sbom/spdx: use compliant license expressions Signed-off-by: Tomáš Hozza <thozza@redhat.com>
194 lines
7.1 KiB
Python
194 lines
7.1 KiB
Python
import os
|
|
from datetime import datetime
|
|
from typing import Dict, List, Optional, Union
|
|
from uuid import uuid4
|
|
|
|
import osbuild
|
|
import osbuild.util.sbom.model as sbom_model
|
|
import osbuild.util.sbom.spdx2 as spdx2
|
|
|
|
try:
|
|
from license_expression import ExpressionError, get_spdx_licensing
|
|
except ImportError:
|
|
get_spdx_licensing = None
|
|
ExpressionError = None
|
|
|
|
|
|
class SpdxLicenseExpressionCreator:
|
|
"""
|
|
Class for creating SPDX license expressions from license strings.
|
|
|
|
This class uses the license-expression package to parse license strings and convert them to SPDX license, if
|
|
possible.
|
|
|
|
The class object also keeps track of all extracted licensing information objects that were created during the
|
|
conversion process. The extracted licensing information objects are stored in a dictionary, where the key is the
|
|
license reference ID and the value is the ExtractedLicensingInfo object.
|
|
"""
|
|
|
|
def __init__(self, license_index_location=None):
|
|
self._extracted_license_infos: Dict[str, spdx2.ExtractedLicensingInfo] = {}
|
|
self._spdx_licensing = None
|
|
|
|
if get_spdx_licensing:
|
|
if license_index_location:
|
|
self._spdx_licensing = get_spdx_licensing(license_index_location)
|
|
else:
|
|
self._spdx_licensing = get_spdx_licensing()
|
|
elif license_index_location:
|
|
raise ValueError("The license-expression package is not available. "
|
|
"Specify the license index location has no effect.")
|
|
|
|
def _to_extracted_license_info(self, license_str: str) -> spdx2.ExtractedLicensingInfo:
|
|
eli = spdx2.ExtractedLicensingInfo(license_str)
|
|
return self._extracted_license_infos.setdefault(eli.license_ref_id, eli)
|
|
|
|
def ensure_license_expression(self, license_str: str) -> Union[str, spdx2.ExtractedLicensingInfo]:
|
|
"""
|
|
Convert a license string to a valid SPDX license expression or wrap it in an ExtractedLicensingInfo object.
|
|
|
|
This function uses the license-expression package to parse the license string and convert it to an SPDX license
|
|
expression. If the license string can't be parsed and converted to an SPDX license expression, it is wrapped in an
|
|
ExtractedLicensingInfo object.
|
|
|
|
If the license-expression package is not available, the license string is always wrapped in an
|
|
ExtractedLicensingInfo object.
|
|
"""
|
|
if self._spdx_licensing is None:
|
|
return self._to_extracted_license_info(license_str)
|
|
|
|
try:
|
|
return str(self._spdx_licensing.parse(license_str, validate=True, strict=True))
|
|
except ExpressionError:
|
|
return self._to_extracted_license_info(license_str)
|
|
|
|
def extracted_license_infos(self) -> List[spdx2.ExtractedLicensingInfo]:
|
|
"""
|
|
Return a list of all extracted licensing information objects that were created during the conversion process.
|
|
"""
|
|
return list(self._extracted_license_infos.values())
|
|
|
|
|
|
def spdx2_checksum_algorithm(algorithm: sbom_model.ChecksumAlgorithm) -> spdx2.ChecksumAlgorithm:
|
|
if algorithm == sbom_model.ChecksumAlgorithm.SHA1:
|
|
return spdx2.ChecksumAlgorithm.SHA1
|
|
if algorithm == sbom_model.ChecksumAlgorithm.SHA224:
|
|
return spdx2.ChecksumAlgorithm.SHA224
|
|
if algorithm == sbom_model.ChecksumAlgorithm.SHA256:
|
|
return spdx2.ChecksumAlgorithm.SHA256
|
|
if algorithm == sbom_model.ChecksumAlgorithm.SHA384:
|
|
return spdx2.ChecksumAlgorithm.SHA384
|
|
if algorithm == sbom_model.ChecksumAlgorithm.SHA512:
|
|
return spdx2.ChecksumAlgorithm.SHA512
|
|
if algorithm == sbom_model.ChecksumAlgorithm.MD5:
|
|
return spdx2.ChecksumAlgorithm.MD5
|
|
raise ValueError(f"Unknown checksum algorithm: {algorithm}")
|
|
|
|
|
|
def create_spdx2_document():
|
|
tool = f"osbuild-{osbuild.__version__}"
|
|
doc_name = f"sbom-by-{tool}"
|
|
|
|
ci = spdx2.CreationInfo(
|
|
spdx_version="SPDX-2.3",
|
|
spdx_id="SPDXRef-DOCUMENT",
|
|
name=doc_name,
|
|
data_license="CC0-1.0",
|
|
document_namespace=f"https://osbuild.org/spdxdocs/{doc_name}-{uuid4()}",
|
|
creators=[spdx2.Creator(spdx2.CreatorType.TOOL, tool)],
|
|
created=datetime.now(),
|
|
)
|
|
doc = spdx2.Document(ci)
|
|
|
|
return doc
|
|
|
|
|
|
def sbom_pkgset_to_spdx2_doc(
|
|
pkgset: List[sbom_model.BasePackage],
|
|
license_index_location: Optional[os.PathLike] = None) -> spdx2.Document:
|
|
doc = create_spdx2_document()
|
|
relationships = []
|
|
license_expr_creator = SpdxLicenseExpressionCreator(license_index_location)
|
|
|
|
for pkg in pkgset:
|
|
|
|
download_location: Union[str, spdx2.NoAssertionValue] = spdx2.NoAssertionValue()
|
|
if pkg.download_url:
|
|
download_location = pkg.download_url
|
|
|
|
license_declared = license_expr_creator.ensure_license_expression(pkg.license_declared)
|
|
|
|
p = spdx2.Package(
|
|
spdx_id=f"SPDXRef-{pkg.uuid()}",
|
|
name=pkg.name,
|
|
download_location=download_location,
|
|
version=pkg.version,
|
|
files_analyzed=False,
|
|
license_declared=license_declared,
|
|
external_references=[
|
|
spdx2.ExternalPackageRef(
|
|
category=spdx2.ExternalPackageRefCategory.PACKAGE_MANAGER,
|
|
reference_type="purl",
|
|
locator=pkg.purl(),
|
|
)
|
|
]
|
|
)
|
|
|
|
if pkg.homepage:
|
|
p.homepage = pkg.homepage
|
|
|
|
if pkg.summary:
|
|
p.summary = pkg.summary
|
|
|
|
if pkg.description:
|
|
p.description = pkg.description
|
|
|
|
if pkg.source_info():
|
|
p.source_info = pkg.source_info()
|
|
|
|
for hash_type, hash_value in pkg.checksums.items():
|
|
p.checksums.append(
|
|
spdx2.Checksum(
|
|
algorithm=spdx2_checksum_algorithm(hash_type),
|
|
value=hash_value,
|
|
)
|
|
)
|
|
|
|
if pkg.build_date:
|
|
p.built_date = pkg.build_date
|
|
|
|
doc.packages.append(p)
|
|
|
|
relationships.append(
|
|
spdx2.Relationship(
|
|
spdx_element_id=doc.creation_info.spdx_id,
|
|
relationship_type=spdx2.RelationshipType.DESCRIBES,
|
|
related_spdx_element_id=p.spdx_id,
|
|
)
|
|
)
|
|
|
|
for dep in sorted(pkg.depends_on, key=lambda x: x.uuid()):
|
|
relationships.append(
|
|
spdx2.Relationship(
|
|
spdx_element_id=p.spdx_id,
|
|
relationship_type=spdx2.RelationshipType.DEPENDS_ON,
|
|
related_spdx_element_id=f"SPDXRef-{dep.uuid()}",
|
|
)
|
|
)
|
|
|
|
for optional_dep in sorted(pkg.optional_depends_on, key=lambda x: x.uuid()):
|
|
relationships.append(
|
|
spdx2.Relationship(
|
|
spdx_element_id=f"SPDXRef-{optional_dep.uuid()}",
|
|
relationship_type=spdx2.RelationshipType.OPTIONAL_DEPENDENCY_OF,
|
|
related_spdx_element_id=p.spdx_id,
|
|
)
|
|
)
|
|
|
|
doc.relationships = relationships
|
|
|
|
extracted_license_infos = license_expr_creator.extracted_license_infos()
|
|
if len(extracted_license_infos) > 0:
|
|
doc.extracted_licensing_infos = extracted_license_infos
|
|
|
|
return doc
|