particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

multiple: check when var is possibly undefined

Browse source 
In cases where a field on an object might be undefined,
rather omit the value than set the field to undefined.
This commit is contained in:
Gianluca Zuccarelli 2024-11-29 14:02:23 +00:00 • committed by Lucas Garfield
parent d4436dc6a9
commit 0d4bb26e0f
15 changed files with 82 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Components/CreateImageWizard/steps/Packages/PackageRecommendations.tsx
View file

@ -62,7 +62,7 @@ const PackageRecommendations = () => {
offset: 0,
});
if (isSuccessDistroRepositories && distroRepositories.data) {
if (isSuccessDistroRepositories && distroRepositories?.data) {
distroRepoUrls = distroRepositories.data.map((repo) => repo.url || '');
}

14
src/Components/CreateImageWizard/steps/Packages/Packages.tsx
View file

@ -267,7 +267,7 @@ const Packages = () => {
apiContentUnitSearchRequest: {
search: debouncedSearchTerm,
urls: distroRepositories
.filter((archItem) => {
?.filter((archItem) => {
return archItem.arch === arch;
})[0]
.repositories.flatMap((repo) => {
@ -329,7 +329,7 @@ const Packages = () => {
apiContentUnitSearchRequest: {
search: debouncedSearchTerm.substr(1),
urls: distroRepositories
.filter((archItem) => {
?.filter((archItem) => {
return archItem.arch === arch;
})[0]
.repositories.flatMap((repo) => {
@ -348,7 +348,7 @@ const Packages = () => {
searchCustomGroups({
apiContentUnitSearchRequest: {
search: debouncedSearchTerm.substr(1),
urls: customRepositories.flatMap((repo) => {
urls: customRepositories?.flatMap((repo) => {
if (!repo.baseurl) {
throw new Error(
`Repository (id: ${repo.id}, name: ${repo?.name}) is missing baseurl`
@ -824,7 +824,7 @@ const Packages = () => {
if (isSelecting) {
if (
isSuccessEpelRepo &&
epelRepo.data &&
epelRepo?.data &&
pkg.repository === 'recommended' &&
!recommendedRepositories.some((repo) => repo.name?.startsWith('EPEL'))
) {
@ -837,7 +837,7 @@ const Packages = () => {
dispatch(removePackage(pkg.name));
if (
isSuccessEpelRepo &&
epelRepo.data &&
epelRepo?.data &&
packages.filter((pkg) => pkg.repository === 'recommended').length ===
1 &&
groups.filter((grp) => grp.repository === 'recommended').length === 0
@ -855,7 +855,7 @@ const Packages = () => {
if (isSelecting) {
if (
isSuccessEpelRepo &&
epelRepo.data &&
epelRepo?.data &&
grp.repository === 'recommended' &&
!recommendedRepositories.some((repo) => repo.name?.startsWith('EPEL'))
) {
@ -868,7 +868,7 @@ const Packages = () => {
dispatch(removeGroup(grp.name));
if (
isSuccessEpelRepo &&
epelRepo.data &&
epelRepo?.data &&
groups.filter((grp) => grp.repository === 'recommended').length === 1 &&
packages.filter((pkg) => pkg.repository === 'recommended').length === 0
) {