particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Wizard: Hotfix for recreate image rate limiting issue

Browse source 
Related to HMS-1886: Clicking the recreate button on a build with a lot
of packages results in the user being rate limited.

Package summaries are obtained by querying the Content Sources API. A
large number of packages requires a large number of requests and leads
to the rate limiting problem when using the 'Recreate image' function.

This commit fixes the problem by not requesting or displaying package
summaries when 'Recreate image' is used. (Note that newly added packages
will still request and display a summary.)

The 'Recreate image' function will soon be replaced by
blueprints. This hotfix should carry us forward until then.
This commit is contained in:
lucasgarfield 2023-06-05 16:56:16 +02:00 • committed by Lucas Garfield
parent b74c166db2
commit 0fe9770bc3
1 changed files with 7 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

79
src/Components/CreateImageWizard/CreateImageWizard.js
View file

@ -263,49 +263,6 @@ const parseSizeUnit = (bytesize) => {
return [size, unit];
};
const getDistributionRepoUrls = (distributionInformation) => {
const filteredArchx86_64 = distributionInformation.find((info) => {
return info.arch === 'x86_64';
});
const mapped = filteredArchx86_64.repositories.map((repo) => repo.baseurl);
return mapped;
};
const getPackageDescription = async (
release,
arch,
repoUrls,
packageName,
isBeta
) => {
let pack;
// if the env is stage beta then use content-sources api
// else use image-builder api
if (isBeta) {
const data = await api.getPackagesContentSources(repoUrls, packageName);
pack = data.find((pack) => packageName === pack.name);
} else {
const args = [release, arch, packageName];
const response = await api.getPackages(...args);
let { data } = response;
const { meta } = response;
// the package should be found in the 0 index
// if not then fetch all package matches and search for the package
if (data[0]?.name === packageName) {
pack = data[0];
} else {
if (data?.length !== meta.count) {
({ data } = await api.getPackages(...args, meta.count));
}
pack = data.find((pack) => packageName === pack.name);
}
}
const summary = pack?.summary;
// if no matching package is found return an empty string for description
return summary || '';
};
// map the compose request object to the expected form state
const requestToState = (composeRequest, distroInfo, isBeta, isProd) => {
if (composeRequest) {
@ -389,35 +346,13 @@ const requestToState = (composeRequest, distroInfo, isBeta, isProd) => {
// customizations
// packages
const packs = [];
let distroRepoUrls = [];
const distro = composeRequest?.distribution;
if (distroInfo) {
distroRepoUrls = getDistributionRepoUrls(distroInfo);
const payloadRepositories =
composeRequest?.customizations?.payload_repositories?.map(
(repo) => repo.baseurl
);
const repoUrls = [...distroRepoUrls];
payloadRepositories ? repoUrls.push(...payloadRepositories) : null;
composeRequest?.customizations?.packages?.forEach(async (packName) => {
const packageDescription = await getPackageDescription(
distro,
imageRequest?.architecture,
repoUrls,
packName,
isBeta
);
const pack = {
name: packName,
summary: packageDescription,
};
packs.push(pack);
});
formState['selected-packages'] = packs;
}
const packages = composeRequest?.customizations?.packages?.map((name) => {
return {
name: name,
summary: undefined,
};
});
formState['selected-packages'] = packages;
// repositories
// 'original-payload-repositories' is treated as read-only and is used to populate