From 18e0dc0cd7e16f84772d34c2bceacff3b0e342e4 Mon Sep 17 00:00:00 2001 From: regexowl Date: Tue, 2 Apr 2024 11:03:04 +0200 Subject: [PATCH] V1Wizard: Add full bottom pagination to Repositories This adds a full pagination to the bottom of the Repositories step. This allows the user to get to the very end of the repositories list easily. --- .../CreateImageWizard/formComponents/Repositories.js | 10 +++++++++- .../CreateImageWizard.content.test.js | 4 ++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/Components/CreateImageWizard/formComponents/Repositories.js b/src/Components/CreateImageWizard/formComponents/Repositories.js index ed9e51aa..07ded098 100644 --- a/src/Components/CreateImageWizard/formComponents/Repositories.js +++ b/src/Components/CreateImageWizard/formComponents/Repositories.js @@ -23,6 +23,7 @@ import { EmptyStateFooter, ToggleGroup, ToggleGroupItem, + PaginationVariant, } from '@patternfly/react-core'; import { Dropdown, @@ -427,7 +428,6 @@ const Repositories = (props) => { perPage={perPage} page={page} onSetPage={handleSetPage} - widgetId="compact-example" onPerPageSelect={handlePerPageSelect} isCompact /> @@ -522,6 +522,14 @@ const Repositories = (props) => { + )} diff --git a/src/test/Components/CreateImageWizard/CreateImageWizard.content.test.js b/src/test/Components/CreateImageWizard/CreateImageWizard.content.test.js index 6d5da43a..476f3794 100644 --- a/src/test/Components/CreateImageWizard/CreateImageWizard.content.test.js +++ b/src/test/Components/CreateImageWizard/CreateImageWizard.content.test.js @@ -1016,7 +1016,7 @@ describe('Step Custom repositories', () => { const firstRepoCheckbox = await getFirstRepoCheckbox(); const getNextPageButton = async () => - await screen.findByRole('button', { + await screen.findAllByRole('button', { name: /go to next page/i, }); @@ -1026,7 +1026,7 @@ describe('Step Custom repositories', () => { await user.click(firstRepoCheckbox); expect(firstRepoCheckbox.checked).toEqual(true); - await user.click(nextPageButton); + await user.click(nextPageButton[0]); const getSelectedButton = async () => await screen.findByRole('button', {