particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Wizard: Fix eslint warnings in Packages step

Browse source 
Most of these fixes are required because of the exhaustive dependencies
rule.
This commit is contained in:
lucasgarfield 2023-11-16 15:18:59 +01:00 • committed by Sanne Raymaekers
parent f1141ec698
commit 196e358aa3
1 changed files with 13 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/Components/CreateImageWizard/formComponents/Packages.js
View file

@ -149,7 +149,7 @@ const Packages = ({ getAllPackages, isSuccess }) => {
}
updateState(oscapPackages);
}
}, [customizations, isSuccessCustomizations]);
}, [customizations, isSuccessCustomizations, updateState]);
// this effect only triggers on mount
useEffect(() => {
@ -203,7 +203,7 @@ const Packages = ({ getAllPackages, isSuccess }) => {
return 0;
};
});
}, []);
const availablePackagesDisplayList = useMemo(() => {
if (availablePackages === undefined) {
@ -213,14 +213,14 @@ const Packages = ({ getAllPackages, isSuccess }) => {
searchResultsComparator(packagesSearchName)
);
return availablePackagesList;
}, [availablePackages]);
}, [availablePackages, packagesSearchName, searchResultsComparator]);
const chosenPackagesDisplayList = useMemo(() => {
const chosenPackagesList = Object.values(chosenPackages)
.filter((pkg) => (pkg.name.includes(filterChosen) ? true : false))
.sort(searchResultsComparator(filterChosen));
return chosenPackagesList;
}, [chosenPackages, filterChosen]);
}, [chosenPackages, filterChosen, searchResultsComparator]);
// call api to list available packages
const handleAvailablePackagesSearch = async () => {
@ -255,12 +255,15 @@ const Packages = ({ getAllPackages, isSuccess }) => {
};
});
const updateState = (newChosenPackages) => {
setSelectedAvailablePackages(new Set());
setSelectedChosenPackages(new Set());
setChosenPackages(newChosenPackages);
change('selected-packages', Object.values(newChosenPackages));
};
const updateState = useCallback(
(newChosenPackages) => {
setSelectedAvailablePackages(new Set());
setSelectedChosenPackages(new Set());
setChosenPackages(newChosenPackages);
change('selected-packages', Object.values(newChosenPackages));
},
[change]
);
const moveSelectedToChosen = () => {
const newChosenPackages = { ...chosenPackages };