diff --git a/playwright/test.spec.ts b/playwright/test.spec.ts index 6538c09e..593247ae 100644 --- a/playwright/test.spec.ts +++ b/playwright/test.spec.ts @@ -92,7 +92,12 @@ test.describe.serial('test', () => { await frame.getByRole('button', { name: 'Create blueprint' }).click(); await expect( - frame.locator('.pf-v6-c-card__title-text').getByText(blueprintName), + frame.locator('.pf-v6-c-card__title-text').getByText( + // if the name is too long, the blueprint card will have a truncated name. + blueprintName.length > 24 + ? blueprintName.slice(0, 24) + '...' + : blueprintName, + ), ).toBeVisible(); }); diff --git a/src/Components/Blueprints/BlueprintCard.tsx b/src/Components/Blueprints/BlueprintCard.tsx index 7bb47aad..8858398c 100644 --- a/src/Components/Blueprints/BlueprintCard.tsx +++ b/src/Components/Blueprints/BlueprintCard.tsx @@ -8,7 +8,6 @@ import { CardHeader, CardTitle, Spinner, - Truncate, } from '@patternfly/react-core'; import { useDeleteBPWithNotification as useDeleteBlueprintMutation } from '../../Hooks'; @@ -51,11 +50,21 @@ const BlueprintCard = ({ blueprint }: blueprintProps) => { onChange: () => dispatch(setBlueprintId(blueprint.id)), }} > - + {isLoading && blueprint.id === selectedBlueprintId && ( )} - + { + // NOTE: This might be an issue with the pf6 truncate component. + // Since we're not really using the popover, we can just + // use vanilla js to truncate the string rather than use the + // Truncate component. We can match the behaviour of the component + // by also splitting on 24 characters. + // https://github.com/patternfly/patternfly-react/issues/11964 + blueprint.name && blueprint.name.length > 24 + ? blueprint.name.slice(0, 24) + '...' + : blueprint.name + } {blueprint.description}