From 3f1a80fbe2749ffe309723a9c2089ca2f9e98cf3 Mon Sep 17 00:00:00 2001 From: regexowl Date: Thu, 3 Jul 2025 10:19:09 +0200 Subject: [PATCH] Run actions with Node 22 The github actions were previously ran with Node 20, this bumps them to Node 22. README was also updated to reflect currently used version of Node. --- .github/workflows/dev-checks.yml | 16 ++++++++-------- .github/workflows/playwright.yml | 2 +- .github/workflows/release.yml | 4 ++-- .github/workflows/unit-tests.yml | 8 ++++---- README.md | 2 +- build_deploy.sh | 2 +- .../steps/Timezone/Timezone.test.tsx | 2 +- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/dev-checks.yml b/.github/workflows/dev-checks.yml index bcea74e8..b67d0cc8 100644 --- a/.github/workflows/dev-checks.yml +++ b/.github/workflows/dev-checks.yml @@ -17,10 +17,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 20 + - name: Use Node.js 22 uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Install dependencies run: npm ci @@ -32,10 +32,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 20 + - name: Use Node.js 22 uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Install dependencies run: npm ci @@ -47,10 +47,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 20 + - name: Use Node.js 22 uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Install dependencies run: npm ci @@ -62,10 +62,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 20 + - name: Use Node.js 22 uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Install dependencies run: npm ci diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 7dd7a378..5e6ee70e 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -37,7 +37,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: "npm" - name: Install front-end dependencies diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 482bcfa8..c6011882 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,10 +13,10 @@ jobs: # artefact name. - uses: actions/checkout@v4 - - name: Use Node.js 20 + - name: Use Node.js 22 uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Install dependencies diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 16214e5d..488cb413 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -19,10 +19,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 20 + - name: Use Node.js 22 uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Install dependencies run: npm ci @@ -40,10 +40,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 20 + - name: Use Node.js 22 uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Install dependencies run: npm ci diff --git a/README.md b/README.md index 14f59267..b0a22d2d 100644 --- a/README.md +++ b/README.md @@ -39,7 +39,7 @@ worrying if a feature from stage has been released yet. #### Nodejs and npm version -Make sure you have npm@10 and node 18+ installed. If you need multiple versions of nodejs check out [nvm](https://github.com/nvm-sh/nvm). +Make sure you have npm@10 and node 22+ installed. If you need multiple versions of nodejs check out [nvm](https://github.com/nvm-sh/nvm). #### Webpack proxy diff --git a/build_deploy.sh b/build_deploy.sh index cbe4db67..11da7b04 100755 --- a/build_deploy.sh +++ b/build_deploy.sh @@ -9,7 +9,7 @@ export COMPONENT="image-builder" export IMAGE="quay.io/cloudservices/image-builder-frontend" export APP_ROOT=$(pwd) export WORKSPACE=${WORKSPACE:-$APP_ROOT} # if running in jenkins, use the build's workspace -export NODE_BUILD_VERSION=18 +export NODE_BUILD_VERSION=22 COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master set -exv diff --git a/src/test/Components/CreateImageWizard/steps/Timezone/Timezone.test.tsx b/src/test/Components/CreateImageWizard/steps/Timezone/Timezone.test.tsx index fe5494a7..129a2661 100644 --- a/src/test/Components/CreateImageWizard/steps/Timezone/Timezone.test.tsx +++ b/src/test/Components/CreateImageWizard/steps/Timezone/Timezone.test.tsx @@ -50,7 +50,7 @@ const goToReviewStep = async () => { }; const selectTimezone = async () => { - const user = userEvent.setup(); + const user = userEvent.setup({ delay: null }); const timezoneDropdown = await screen.findByPlaceholderText( /select a timezone/i );