particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CreateImageWizard/Registration: remove extra rhc/insights vars

Browse source 
They just complicated the logic, might as well rely on the form api
value.
This commit is contained in:
Sanne Raymaekers 2023-03-13 11:58:41 +01:00
parent 9d0448979d
commit 808d8b8452
1 changed files with 14 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

48
src/Components/CreateImageWizard/formComponents/Registration.js
View file

@ -136,34 +136,18 @@ const Registration = ({ label, ...props }) => {
const { change, getState } = useFormApi();
const { input } = useFieldApi(props);
const [showOptions, setShowOptions] = useState(false);
const [insights, setInsights] = useState(true);
const [rhc, setRhc] = useState(true);
const registerSystem = getState()?.values?.['register-system'];
useEffect(() => {
if (registerSystem === 'register-now-insights') {
setShowOptions(true);
setInsights(true);
setRhc(false);
}
if (registerSystem === 'register-now') {
setShowOptions(true);
setInsights(false);
setRhc(false);
}
}, []);
useEffect(() => {
if (insights && rhc) {
change(input.name, 'register-now-rhc');
} else if (insights && !rhc) {
change(input.name, 'register-now-insights');
} else if (!insights && !rhc) {
change(input.name, 'register-now');
}
}, [insights, rhc]);
return (
<FormSpy>
{() => (
@ -184,14 +168,7 @@ const Registration = ({ label, ...props }) => {
id="register-system-now"
checked={registerSystem.startsWith('register-now')}
onChange={() => {
// If rhc (or insights) was disabled previously, enable them again
if (!rhc) {
setInsights(true);
setRhc(true);
} else {
// useEffect[insights, rhc] won't be triggered if both insights and rhc were enabled
change(input.name, 'register-now-rhc');
}
change(input.name, 'register-now-rhc');
}}
description={
!showOptions && (
@ -218,12 +195,15 @@ const Registration = ({ label, ...props }) => {
</>
}
data-testid="registration-checkbox-insights"
isChecked={insights}
isChecked={
registerSystem === 'register-now-insights' ||
registerSystem === 'register-now-rhc'
}
onChange={(checked) => {
setInsights(checked);
// Uncheck rhc if insights is being unchecked
if (!checked) {
setRhc(!insights);
if (checked) {
change(input.name, 'register-now-insights');
} else {
change(input.name, 'register-now');
}
}}
id="register-system-now-insights"
@ -238,12 +218,12 @@ const Registration = ({ label, ...props }) => {
</>
}
data-testid="registration-checkbox-rhc"
isChecked={rhc}
isChecked={registerSystem === 'register-now-rhc'}
onChange={(checked) => {
setRhc(checked);
// Enable insights if not already enabled
if (!insights) {
setInsights(true);
if (checked) {
change(input.name, 'register-now-rhc');
} else {
change(input.name, 'register-now-insights');
}
}}
id="register-system-now-rhc"