particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

src: Remove more data-testids

Browse source 
As using `data-testid`s in tests is an anti-pattern, this removes more of them and replaces them with appropriate locators in the tests.
This commit is contained in:
regexowl 2025-05-08 10:22:33 +02:00 • committed by Gianluca Zuccarelli
parent 0ea874abc6
commit a0fe3644c3
26 changed files with 257 additions and 160 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/Components/CreateImageWizard/steps/TargetEnvironment/Azure/AzureHyperVSelect.tsx
View file

@ -47,7 +47,6 @@ export const AzureHyperVSelect = () => {
const toggle = (toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle
ref={toggleRef}
data-testid="azure-hyper-v-generation-select"
onClick={() => setIsOpen(!isOpen)}
isExpanded={isOpen}
>

5
src/Components/CreateImageWizard/steps/TargetEnvironment/Gcp/index.tsx
View file

@ -66,7 +66,6 @@ const Gcp = () => {
/>
<Radio
id="share-with-insights"
data-testid="share-with-insights"
label="Share image with Red Hat Insights only"
name="radio-2"
description={
@ -88,7 +87,6 @@ const Gcp = () => {
<FormGroup label="Account type" isRequired>
<Radio
id="google-account"
data-testid="google-account"
label="Google account"
name="radio-3"
isChecked={accountType === 'user'}
@ -98,7 +96,6 @@ const Gcp = () => {
/>
<Radio
id="service-account"
data-testid="service-account"
label="Service account"
name="radio-4"
isChecked={accountType === 'serviceAccount'}
@ -108,7 +105,6 @@ const Gcp = () => {
/>
<Radio
id="google-group"
data-testid="google-group"
label="Google group"
name="radio-5"
isChecked={accountType === 'group'}
@ -118,7 +114,6 @@ const Gcp = () => {
/>
<Radio
id="google-domain"
data-testid="google-domain"
label="Google Workspace domain or Cloud Identity domain"
name="radio-6"
isChecked={accountType === 'domain'}