particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ImagesTable: Fix bug where failed AWS images showed sharing error

Browse source 
Failed AWS images showed a `Failed to share image to one or more regions.` error even though they weren't shared to other regions.

This was caused by checking for a 'failure' status in an array of `imageStatuses` that included the parent status.
This commit is contained in:
regexowl 2023-07-21 11:48:03 +02:00 • committed by Sanne Raymaekers
parent d685245b9b
commit b8d56fff15
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/Components/ImagesTable/ImageBuildStatus.js
View file

@ -42,9 +42,7 @@ export const ImageBuildStatus = ({
const cloneErrorMessage = () => {
let region = '';
hasFailedClone.includes(image.id)
? (region = 'one or more regions')
: (region = imageRegion);
hasFailedClone ? (region = 'one or more regions') : (region = imageRegion);
return {
error: {
reason: `Failed to share image to ${region}.`,
@ -121,7 +119,7 @@ export const ImageBuildStatus = ({
],
};
const hasFailedClone = [];
let hasFailedClone;
let status;
if (
isImagesTableRow &&
@ -136,8 +134,12 @@ export const ImageBuildStatus = ({
const imageStatuses = useSelector((state) =>
selectImageStatusesById(state, image.id)
);
if (imageStatuses.includes('failure')) {
hasFailedClone.push(image.id);
if (!imageStatuses.includes('success')) {
hasFailedClone = false;
} else if (!imageStatuses.includes('failure')) {
hasFailedClone = false;
} else {
hasFailedClone = true;
}
const filteredImageStatuses = imageStatuses.filter(
(imageStatus) => imageStatus !== undefined
@ -183,7 +185,7 @@ export const ImageBuildStatus = ({
<PanelMain maxHeight="25rem">
<ErrorDetails
status={
!imageStatus || hasFailedClone.includes(image.id)
!imageStatus || hasFailedClone
? cloneErrorMessage()
: imageStatus
}