particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Wizard: Image name validation

Browse source 
This adds validation of an image name based on a pattern, which was chosen as an intersection of the naming constrains of hyperscalers.

The pattern is based on the one for naming GCP images as those naming guidelines are the most restrictive. With added minimal length restriction of AWS.
This commit is contained in:
regexowl 2023-05-15 17:01:51 +02:00 • committed by Sanne Raymaekers
parent ccd5a5c830
commit c4f616763d
3 changed files with 23 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/test/Components/CreateImageWizard/CreateImageWizard.beta.test.js
View file

@ -740,7 +740,7 @@ describe('Click through all steps', () => {
const nameInput = screen.getByRole('textbox', {
name: 'Image name',
});
await user.type(nameInput, 'MyImageName');
await user.type(nameInput, 'my-image-name');
getNextButton().click();
// review
@ -767,7 +767,7 @@ describe('Click through all steps', () => {
'image-details-expandable'
);
imageDetailsExpandable.click();
await screen.findByText('MyImageName');
await screen.findByText('my-image-name');
await screen.findByText('name0');
await screen.findByText('Self-Support');
@ -793,7 +793,7 @@ describe('Click through all steps', () => {
if (body.image_requests[0].upload_request.type === 'aws') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -812,7 +812,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].upload_request.type === 'gcp') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -831,7 +831,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].upload_request.type === 'azure') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -852,7 +852,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].image_type === 'vsphere-ova') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -869,7 +869,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].image_type === 'guest-image') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -886,7 +886,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].image_type === 'image-installer') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',

22
src/test/Components/CreateImageWizard/CreateImageWizard.test.js
View file

@ -1105,7 +1105,7 @@ describe('Step Details', () => {
getNextButton().click();
};
test('image name invalid for more than 100 chars', async () => {
test('image name invalid for more than 63 chars', async () => {
await setUp();
// Enter image name
@ -1113,12 +1113,12 @@ describe('Step Details', () => {
name: 'Image name',
});
// 101 character name
const invalidName = 'a'.repeat(101);
const invalidName = 'a'.repeat(64);
await user.type(nameInput, invalidName);
expect(getNextButton()).toHaveClass('pf-m-disabled');
expect(getNextButton()).toBeDisabled();
await user.clear(nameInput);
await user.type(nameInput, 'validName');
await user.type(nameInput, 'valid-name');
expect(getNextButton()).not.toHaveClass('pf-m-disabled');
expect(getNextButton()).toBeEnabled();
});
@ -1386,7 +1386,7 @@ describe('Click through all steps', () => {
const nameInput = screen.getByRole('textbox', {
name: 'Image name',
});
await user.type(nameInput, 'MyImageName');
await user.type(nameInput, 'my-image-name');
getNextButton().click();
// review
@ -1404,7 +1404,7 @@ describe('Click through all steps', () => {
'image-details-expandable'
);
imageDetailsExpandable.click();
await screen.findByText('MyImageName');
await screen.findByText('my-image-name');
const registrationExpandable = await screen.findByTestId(
'registration-expandable'
@ -1438,7 +1438,7 @@ describe('Click through all steps', () => {
if (body.image_requests[0].upload_request.type === 'aws') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -1481,7 +1481,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].upload_request.type === 'gcp') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -1524,7 +1524,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].upload_request.type === 'azure') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -1569,7 +1569,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].image_type === 'vsphere-ova') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -1610,7 +1610,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].image_type === 'guest-image') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',
@ -1651,7 +1651,7 @@ describe('Click through all steps', () => {
} else if (body.image_requests[0].image_type === 'image-installer') {
expect(body).toEqual({
distribution: RHEL_8,
image_name: 'MyImageName',
image_name: 'my-image-name',
image_requests: [
{
architecture: 'x86_64',