From c6f74efcb3cf05ffd929bfd643140c5531f86a5e Mon Sep 17 00:00:00 2001 From: Chloe Kaubisch Date: Mon, 22 Nov 2021 19:53:49 +0100 Subject: [PATCH] CreateImageWizard: don't obscure activation key Activation key was previously obscured by stars, instead just show it (both in the input and in the review step) as it isn't secret. --- src/Components/CreateImageWizard/formComponents/ReviewStep.js | 2 +- src/Components/CreateImageWizard/steps/registration.js | 2 +- src/test/Components/CreateImageWizard/CreateImageWizard.test.js | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Components/CreateImageWizard/formComponents/ReviewStep.js b/src/Components/CreateImageWizard/formComponents/ReviewStep.js index ae690f22..e9b07ee4 100644 --- a/src/Components/CreateImageWizard/formComponents/ReviewStep.js +++ b/src/Components/CreateImageWizard/formComponents/ReviewStep.js @@ -128,7 +128,7 @@ const ReviewStep = () => { Activation key - {'*'.repeat(getState()?.values?.['subscription-activation']?.length)} + {getState()?.values?.['subscription-activation']} diff --git a/src/Components/CreateImageWizard/steps/registration.js b/src/Components/CreateImageWizard/steps/registration.js index c49217ff..b5217da4 100644 --- a/src/Components/CreateImageWizard/steps/registration.js +++ b/src/Components/CreateImageWizard/steps/registration.js @@ -47,7 +47,7 @@ export default (user) => ({ name: 'subscription-activation', 'data-testid': 'subscription-activation', required: true, - type: 'password', + type: 'text', label: 'Activation key', condition: { or: [ diff --git a/src/test/Components/CreateImageWizard/CreateImageWizard.test.js b/src/test/Components/CreateImageWizard/CreateImageWizard.test.js index 90177d17..810b193a 100644 --- a/src/test/Components/CreateImageWizard/CreateImageWizard.test.js +++ b/src/test/Components/CreateImageWizard/CreateImageWizard.test.js @@ -369,6 +369,7 @@ describe('Step Registration', () => { screen.getByRole('button', { name: /Next/ }).click(); screen.getByRole('button', { name: /Next/ }).click(); await screen.findByText('Register the system on first boot'); + await screen.findAllByText('012345678901'); }); test('should hide input fields when clicking Register the system later', async () => {