particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Utilities: Add useExperimentalFlag hook

Browse source 
This commit DRYs out the code, extracting the logic for setting the
value of the experimentalFlag into a new hook found in the utilities.

It also makes the typing stricter - the hook returns a boolean. The
pattern we were using previously to set the value of experimentalFlag
variables could be boolean, string, or undefined.
This commit is contained in:
lucasgarfield 2024-03-05 18:14:27 +01:00 • committed by Lucas Garfield
parent baddf66273
commit c73482dd7f
4 changed files with 32 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/Components/ImagesTable/ImagesTable.tsx
View file

@ -22,7 +22,6 @@ import {
Thead,
Tr,
} from '@patternfly/react-table';
import { useFlag } from '@unleash/proxy-client-react';
import { Link, NavigateFunction, useNavigate } from 'react-router-dom';
import './ImagesTable.scss';
@ -58,7 +57,7 @@ import {
computeHoursToExpiration,
timestampToDisplayString,
} from '../../Utilities/time';
import { useGetEnvironment } from '../../Utilities/useGetEnvironment';
import { useExperimentalFlag } from '../../Utilities/useExperimentalFlag';
import { BlueprintActionsMenu } from '../Blueprints/BlueprintActionsMenu';
import { BuildImagesButton } from '../Blueprints/BuildImagesButton';
import { DeleteBlueprintModal } from '../Blueprints/DeleteBlueprintModal';
@ -86,8 +85,7 @@ const ImagesTable = ({
}),
}
);
const experimentalFlag =
useFlag('image-builder.new-wizard.enabled') || process.env.EXPERIMENTAL;
const experimentalFlag = useExperimentalFlag();
const onSetPage: OnSetPage = (_, page) => setPage(page);
const onPerPageSelect: OnSetPage = (_, perPage) => {
@ -498,10 +496,7 @@ const Row = ({
}: RowPropTypes) => {
const [isExpanded, setIsExpanded] = useState(false);
const handleToggle = () => setIsExpanded(!isExpanded);
const { isBeta } = useGetEnvironment();
const experimentalFlag =
(useFlag('image-builder.new-wizard.enabled') || process.env.EXPERIMENTAL) &&
isBeta();
const experimentalFlag = useExperimentalFlag();
const navigate = useNavigate();
return (