From c9d721ea5203dc1a208ee70253e37379d08b3697 Mon Sep 17 00:00:00 2001
From: Gianluca Zuccarelli <gianlucazuccarelli@gmail.com>
Date: Fri, 11 Jul 2025 10:43:02 +0100
Subject: [PATCH] playwright: add a test for cockpit cloud config

SSIA
---
 playwright/test.spec.ts                       | 73 +++++++++++++++++++
 schutzbot/playwright_tests.sh                 |  1 +
 .../CloudProviderConfig/AWSConfig.tsx         |  2 +
 3 files changed, 76 insertions(+)

diff --git a/playwright/test.spec.ts b/playwright/test.spec.ts
index 87d180a3..4bec2f84 100644
--- a/playwright/test.spec.ts
+++ b/playwright/test.spec.ts
@@ -1,3 +1,6 @@
+import { readFileSync } from 'node:fs';
+
+import TOML from '@ltd/j-toml';
 import { expect, test } from '@playwright/test';
 import { v4 as uuidv4 } from 'uuid';
 
@@ -165,4 +168,74 @@ test.describe.serial('test', () => {
     await frame.getByRole('menuitem', { name: 'Delete blueprint' }).click();
     await frame.getByRole('button', { name: 'Delete' }).click();
   });
+
+  test('cockpit worker config', async ({ page }) => {
+    if (isHosted()) {
+      return;
+    }
+
+    await ensureAuthenticated(page);
+    await closePopupsIfExist(page);
+    // Navigate to IB landing page and get the frame
+    await navigateToLandingPage(page);
+    await page.goto('/cockpit-image-builder');
+    const frame = ibFrame(page);
+
+    const header = frame.getByText('Configure AWS Uploads');
+    if (!(await header.isVisible())) {
+      await frame
+        .getByRole('button', { name: 'Configure Cloud Providers' })
+        .click();
+      await expect(header).toBeVisible();
+    }
+
+    const bucket = 'cockpit-ib-playwright-bucket';
+    const credentials = '/test/credentials';
+    const switchInput = frame.locator('#aws-config-switch');
+    await expect(switchInput).toBeVisible();
+
+    // the test is a little bit flaky, if it fails the first time
+    // while setting the configs, the second time the config should
+    // already be loaded and visible, if it is go back to the landing page
+    // https://github.com/osbuild/image-builder-frontend/issues/3429
+    if (await switchInput.isChecked()) {
+      await frame.getByRole('button', { name: 'Cancel' }).click();
+      await expect(
+        frame.getByRole('heading', { name: 'All images' })
+      ).toBeVisible();
+    } else {
+      const switchToggle = frame.locator('.pf-v6-c-switch');
+      await switchToggle.click();
+
+      await frame
+        .getByPlaceholder('AWS bucket')
+        // this doesn't need to exist, we're just testing that
+        // the form works as expected
+        .fill(bucket);
+      await frame.getByPlaceholder('Path to AWS credentials').fill(credentials);
+      await frame.getByRole('button', { name: 'Submit' }).click();
+      await expect(
+        frame.getByRole('heading', { name: 'All images' })
+      ).toBeVisible();
+    }
+
+    const config = readFileSync('/etc/osbuild-worker/osbuild-worker.toml');
+    // this is for testing, the field `aws` should exist
+    // eslint-disable-next-line
+    const parsed = TOML.parse(config) as any;
+    expect(parsed.aws?.bucket).toBe(bucket);
+    expect(parsed.aws?.credentials).toBe(credentials);
+
+    await frame
+      .getByRole('button', { name: 'Configure Cloud Providers' })
+      .click();
+    await expect(header).toBeVisible();
+    await expect(frame.locator('#aws-config-switch')).toBeChecked();
+
+    await expect(frame.getByPlaceholder('AWS bucket')).toHaveValue(bucket);
+    await expect(frame.getByPlaceholder('Path to AWS credentials')).toHaveValue(
+      credentials
+    );
+    await frame.getByRole('button', { name: 'Cancel' }).click();
+  });
 });
diff --git a/schutzbot/playwright_tests.sh b/schutzbot/playwright_tests.sh
index 21fcd9ef..d6a5a87f 100755
--- a/schutzbot/playwright_tests.sh
+++ b/schutzbot/playwright_tests.sh
@@ -77,6 +77,7 @@ sudo podman run \
      -e "CURRENTS_RECORD_KEY=$CURRENTS_RECORD_KEY" \
      --net=host \
      -v "$PWD:/tests" \
+     -v '/etc:/etc' \
      --privileged  \
      --rm \
      --init \
diff --git a/src/Components/CloudProviderConfig/AWSConfig.tsx b/src/Components/CloudProviderConfig/AWSConfig.tsx
index e3f2c2a4..1051767a 100644
--- a/src/Components/CloudProviderConfig/AWSConfig.tsx
+++ b/src/Components/CloudProviderConfig/AWSConfig.tsx
@@ -86,6 +86,7 @@ const AWSBucket = ({ value, onChange, isDisabled }: FormGroupProps<string>) => {
   return (
     <FormGroup label={label}>
       <ValidatedInput
+        placeholder="AWS bucket"
         ariaLabel="aws-bucket"
         value={value || ''}
         validator={isAwsBucketValid}
@@ -146,6 +147,7 @@ const AWSCredsPath = ({
   return (
     <FormGroup label={label}>
       <ValidatedInput
+        placeholder="Path to AWS credentials"
         ariaLabel="aws-creds-path"
         value={value || ''}
         validator={isAwsCredsPathValid}