wizard: don't show the form as a modal
When the user clicks on the "create an image" button, the image wizard shows up replacing the landing page. This allows to keep the quickstart guides to the right of the wizard while the user is interacting with it.
This commit is contained in:
parent
cd2d3c41f7
commit
cbe710e75e
4 changed files with 28 additions and 11 deletions
|
|
@ -641,7 +641,7 @@ const CreateImageWizard = () => {
|
||||||
name: 'image-builder-wizard',
|
name: 'image-builder-wizard',
|
||||||
className: 'imageBuilder',
|
className: 'imageBuilder',
|
||||||
isDynamic: true,
|
isDynamic: true,
|
||||||
inModal: true,
|
inModal: false,
|
||||||
onKeyDown: (e) => {
|
onKeyDown: (e) => {
|
||||||
handleKeyDown(e, handleClose);
|
handleKeyDown(e, handleClose);
|
||||||
},
|
},
|
||||||
|
|
@ -649,7 +649,7 @@ const CreateImageWizard = () => {
|
||||||
submit: 'Create image',
|
submit: 'Create image',
|
||||||
},
|
},
|
||||||
showTitles: true,
|
showTitles: true,
|
||||||
title: 'Create image',
|
title: 'Image Builder',
|
||||||
crossroads: [
|
crossroads: [
|
||||||
'target-environment',
|
'target-environment',
|
||||||
'release',
|
'release',
|
||||||
|
|
|
||||||
|
|
@ -59,3 +59,20 @@ ul.pf-m-plain {
|
||||||
padding-left: 0;
|
padding-left: 0;
|
||||||
margin-left: 0;
|
margin-left: 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// [2023-09] Wizard height should not be limited see
|
||||||
|
// https://github.com/data-driven-forms/react-forms/issues/1402
|
||||||
|
// TODO remove me after DDF is not used anymore
|
||||||
|
.pf-c-wizard__main {
|
||||||
|
overflow-x: unset;
|
||||||
|
overflow-y: unset;
|
||||||
|
}
|
||||||
|
// TODO remove me after DDF is not used anymore
|
||||||
|
.pf-c-wizard__footer {
|
||||||
|
z-index: unset;
|
||||||
|
}
|
||||||
|
// [2023-10] Wizard closing cross shouldn't get displayed
|
||||||
|
// TODO remove me after DDF is not used anymore
|
||||||
|
.pf-c-wizard__header .pf-c-button.pf-m-plain {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
|
||||||
|
|
@ -24,17 +24,17 @@ export const Router = () => {
|
||||||
</Suspense>
|
</Suspense>
|
||||||
}
|
}
|
||||||
>
|
>
|
||||||
<Route
|
|
||||||
path="imagewizard/:composeId?"
|
|
||||||
element={
|
|
||||||
<Suspense>
|
|
||||||
<CreateImageWizard />
|
|
||||||
</Suspense>
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
<Route path="share/:composeId" element={<ShareImageModal />} />
|
<Route path="share/:composeId" element={<ShareImageModal />} />
|
||||||
</Route>
|
</Route>
|
||||||
|
|
||||||
|
<Route
|
||||||
|
path="imagewizard/:composeId?"
|
||||||
|
element={
|
||||||
|
<Suspense>
|
||||||
|
<CreateImageWizard />
|
||||||
|
</Suspense>
|
||||||
|
}
|
||||||
|
/>
|
||||||
{edgeParityFlag && (
|
{edgeParityFlag && (
|
||||||
<Route
|
<Route
|
||||||
path={`/${manageEdgeImagesUrlName}/:imageId`}
|
path={`/${manageEdgeImagesUrlName}/:imageId`}
|
||||||
|
|
|
||||||
|
|
@ -118,7 +118,7 @@ describe('Create Image Wizard', () => {
|
||||||
test('renders component', () => {
|
test('renders component', () => {
|
||||||
renderCustomRoutesWithReduxRouter('imagewizard', {}, routes);
|
renderCustomRoutesWithReduxRouter('imagewizard', {}, routes);
|
||||||
// check heading
|
// check heading
|
||||||
screen.getByRole('heading', { name: /Create image/ });
|
screen.getByRole('heading', { name: /Image Builder/ });
|
||||||
|
|
||||||
screen.getByRole('button', { name: 'Image output' });
|
screen.getByRole('button', { name: 'Image output' });
|
||||||
screen.getByRole('button', { name: 'Register' });
|
screen.getByRole('button', { name: 'Register' });
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue