From d4cb1c4d6ba83fe41e69700dc1b855bffed5e500 Mon Sep 17 00:00:00 2001 From: Xiaofeng Wang Date: Fri, 6 Nov 2020 09:33:06 +0800 Subject: [PATCH] test: Add two more eslint plugin to follow best practices and anticipate common mistakes eslint-plugin-testing-library: for writing tests with Testing Library eslint-plugin-jest-dom: for writing tests with jest-dom --- package.json | 2 ++ src/test/.eslintrc | 10 +++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 124aae2e..3ed068fc 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,9 @@ "eslint": "^6.8.0", "eslint-config-prettier": "^6.10.0", "eslint-loader": "^3.0.3", + "eslint-plugin-jest-dom": "^3.2.4", "eslint-plugin-react": "^7.18.3", + "eslint-plugin-testing-library": "^3.10.0", "identity-obj-proxy": "^3.0.0", "jest": "^26.1.0", "npm-run-all": "^4.1.5", diff --git a/src/test/.eslintrc b/src/test/.eslintrc index 999bc874..4fccc167 100644 --- a/src/test/.eslintrc +++ b/src/test/.eslintrc @@ -3,8 +3,16 @@ "jest": true, "es6": true }, + "plugins": [ + "testing-library", + "jest-dom" + ], "rules": { "react/display-name": "off", "react/prop-types": "off" - } + }, + "extends": [ + "plugin:testing-library/react", + "plugin:jest-dom/recommended" + ] }