From d8bb3485d8a66a4f7ff4f6d7be4a311d6b19d8bc Mon Sep 17 00:00:00 2001 From: regexowl Date: Mon, 25 Nov 2024 09:42:09 +0100 Subject: [PATCH] Wizard: Add v5 PF slug to classNames This adds v5 PF slug to classNames throughout the code base, making the formatting work properly. --- .../CreateImageWizard/CreateImageWizard.scss | 18 +++---- ...ileSystemAutomaticPartitionInformation.tsx | 2 +- .../FileSystem/FileSystemConfiguration.tsx | 4 +- .../steps/FileSystem/FileSystemTable.tsx | 2 +- .../steps/ImageOutput/TargetEnvironment.tsx | 16 +++---- .../CreateImageWizard/steps/Oscap/Oscap.tsx | 2 +- .../steps/Oscap/OscapProfileInformation.tsx | 12 ++--- .../steps/Packages/Packages.tsx | 10 ++-- .../PackageInfoNotAvailablePopover.tsx | 2 +- .../Registration/ActivationKeyInformation.tsx | 6 +-- .../steps/Registration/ActivationKeysList.tsx | 2 +- .../steps/Registration/Registration.tsx | 6 +-- .../steps/Repositories/RepositoriesStatus.tsx | 6 +-- .../steps/Repositories/components/Empty.tsx | 2 +- .../steps/Review/ReviewStep.tsx | 4 +- .../steps/Review/ReviewStepTextLists.tsx | 38 +++++++-------- src/Components/ImagesTable/EmptyState.tsx | 2 +- src/Components/ImagesTable/ImageDetails.tsx | 48 +++++++++++-------- src/Components/ImagesTable/ImagesTable.tsx | 2 +- src/Components/ImagesTable/Instance.tsx | 4 +- src/Components/ImagesTable/Status.tsx | 14 +++--- src/Components/LandingPage/LandingPage.scss | 6 +-- src/Components/LandingPage/Quickstarts.tsx | 18 +++---- .../ShareImageModal/RegionsSelect.tsx | 2 +- .../sharedComponents/BetaLabel.scss | 4 +- .../sharedComponents/ImageBuilderHeader.tsx | 2 +- 26 files changed, 122 insertions(+), 112 deletions(-) diff --git a/src/Components/CreateImageWizard/CreateImageWizard.scss b/src/Components/CreateImageWizard/CreateImageWizard.scss index b3f3c566..ad52466f 100644 --- a/src/Components/CreateImageWizard/CreateImageWizard.scss +++ b/src/Components/CreateImageWizard/CreateImageWizard.scss @@ -15,11 +15,11 @@ } .pf-c-form { - --pf-c-form--GridGap: var(--pf-global--spacer--md); + --pf-c-form--GridGap: var(--pf-v5-global--spacer--md); } .pf-c-form__group-label { - --pf-c-form__group-label--PaddingBottom: var(--pf-global--spacer--xs); + --pf-c-form__group-label--PaddingBottom: var(--pf-v5-global--spacer--xs); } .tiles { @@ -33,9 +33,9 @@ .pf-c-tile:focus { --pf-c-tile__title--Color: var(--pf-c-tile__title--Color); - --pf-c-tile__icon--Color: var(---pf-global--Color--100); - --pf-c-tile--before--BorderWidth: var(--pf-global--BorderWidth--sm); - --pf-c-tile--before--BorderColor: var(--pf-global--BorderColor--100); + --pf-c-tile__icon--Color: var(---pf-v5-global--Color--100); + --pf-c-tile--before--BorderWidth: var(--pf-v5-global--BorderWidth--sm); + --pf-c-tile--before--BorderColor: var(--pf-v5-global--BorderColor--100); } .pf-c-tile.pf-m-selected:focus { @@ -48,12 +48,12 @@ height: 1em; } -.pf-u-min-width { - --pf-u-min-width--MinWidth: 18ch; +.pf-v5-u-min-width { + --pf-v5-u-min-width--MinWidth: 18ch; } -.pf-u-max-width { - --pf-u-max-width--MaxWidth: 26rem; +.pf-v5-u-max-width { + --pf-v5-u-max-width--MaxWidth: 26rem; } ul.pf-m-plain { diff --git a/src/Components/CreateImageWizard/steps/FileSystem/FileSystemAutomaticPartitionInformation.tsx b/src/Components/CreateImageWizard/steps/FileSystem/FileSystemAutomaticPartitionInformation.tsx index e30066b8..cd5959a3 100644 --- a/src/Components/CreateImageWizard/steps/FileSystem/FileSystemAutomaticPartitionInformation.tsx +++ b/src/Components/CreateImageWizard/steps/FileSystem/FileSystemAutomaticPartitionInformation.tsx @@ -27,7 +27,7 @@ const FileSystemAutomaticPartition = () => { icon={} iconPosition="right" href={FILE_SYSTEM_CUSTOMIZATION_URL} - className="pf-u-pl-0" + className="pf-v5-u-pl-0" > Customizing file systems during the image creation diff --git a/src/Components/CreateImageWizard/steps/FileSystem/FileSystemConfiguration.tsx b/src/Components/CreateImageWizard/steps/FileSystem/FileSystemConfiguration.tsx index c1b555a0..49288cf0 100644 --- a/src/Components/CreateImageWizard/steps/FileSystem/FileSystemConfiguration.tsx +++ b/src/Components/CreateImageWizard/steps/FileSystem/FileSystemConfiguration.tsx @@ -65,7 +65,7 @@ const FileSystemConfiguration = () => { icon={} iconPosition="right" href={FILE_SYSTEM_CUSTOMIZATION_URL} - className="pf-u-pl-0" + className="pf-v5-u-pl-0" > Read more about manual configuration here @@ -83,7 +83,7 @@ const FileSystemConfiguration = () => { diff --git a/src/Components/CreateImageWizard/steps/ImageOutput/TargetEnvironment.tsx b/src/Components/CreateImageWizard/steps/ImageOutput/TargetEnvironment.tsx index c969ff9e..dacd1f02 100644 --- a/src/Components/CreateImageWizard/steps/ImageOutput/TargetEnvironment.tsx +++ b/src/Components/CreateImageWizard/steps/ImageOutput/TargetEnvironment.tsx @@ -98,7 +98,7 @@ const TargetEnvironment = () => {
{supportedEnvironments?.includes('aws') && ( { )} {supportedEnvironments?.includes('gcp') && ( { )} {supportedEnvironments?.includes('azure') && ( { )} {supportedEnvironments?.includes('oci') && ( { <> Private cloud} - className="pf-u-mt-sm" + className="pf-v5-u-mt-sm" data-testid="target-private" > { } > diff --git a/src/Components/CreateImageWizard/steps/Oscap/OscapProfileInformation.tsx b/src/Components/CreateImageWizard/steps/Oscap/OscapProfileInformation.tsx index 55e79c1b..ccece346 100644 --- a/src/Components/CreateImageWizard/steps/Oscap/OscapProfileInformation.tsx +++ b/src/Components/CreateImageWizard/steps/Oscap/OscapProfileInformation.tsx @@ -102,7 +102,7 @@ export const OscapProfileInformation = ({ Profile description: @@ -111,7 +111,7 @@ export const OscapProfileInformation = ({ Operating system: @@ -120,7 +120,7 @@ export const OscapProfileInformation = ({ Reference ID: @@ -132,7 +132,7 @@ export const OscapProfileInformation = ({ Kernel arguments: @@ -145,7 +145,7 @@ export const OscapProfileInformation = ({ Disabled services: @@ -158,7 +158,7 @@ export const OscapProfileInformation = ({ Enabled services: diff --git a/src/Components/CreateImageWizard/steps/Packages/Packages.tsx b/src/Components/CreateImageWizard/steps/Packages/Packages.tsx index d35c9856..883b1a34 100644 --- a/src/Components/CreateImageWizard/steps/Packages/Packages.tsx +++ b/src/Components/CreateImageWizard/steps/Packages/Packages.tsx @@ -541,7 +541,7 @@ const Packages = () => { @@ -1308,7 +1308,7 @@ const Packages = () => { variant="plain" aria-label="About included repositories" component="span" - className="pf-u-p-0" + className="pf-v5-u-p-0" size="sm" isInline > @@ -1339,7 +1339,7 @@ const Packages = () => { variant="plain" aria-label="About other repositories" component="span" - className="pf-u-p-0" + className="pf-v5-u-p-0" size="sm" isInline > diff --git a/src/Components/CreateImageWizard/steps/Packages/components/PackageInfoNotAvailablePopover.tsx b/src/Components/CreateImageWizard/steps/Packages/components/PackageInfoNotAvailablePopover.tsx index b477ad89..6ef60a47 100644 --- a/src/Components/CreateImageWizard/steps/Packages/components/PackageInfoNotAvailablePopover.tsx +++ b/src/Components/CreateImageWizard/steps/Packages/components/PackageInfoNotAvailablePopover.tsx @@ -23,7 +23,7 @@ const PackageInfoNotAvailablePopover = () => { diff --git a/src/Components/CreateImageWizard/steps/Registration/ActivationKeyInformation.tsx b/src/Components/CreateImageWizard/steps/Registration/ActivationKeyInformation.tsx index b092f073..fea15ed2 100644 --- a/src/Components/CreateImageWizard/steps/Registration/ActivationKeyInformation.tsx +++ b/src/Components/CreateImageWizard/steps/Registration/ActivationKeyInformation.tsx @@ -80,7 +80,7 @@ const ActivationKeyInformation = (): JSX.Element => { @@ -88,7 +88,7 @@ const ActivationKeyInformation = (): JSX.Element => { {activationKeyInfo.body?.additionalRepositories && activationKeyInfo.body?.additionalRepositories?.length > 0 ? ( @@ -126,7 +126,7 @@ const ActivationKeyInformation = (): JSX.Element => { data-testid="repositories-popover-button" variant="link" aria-label="Show additional repositories" - className="pf-u-pl-0 pf-u-pt-0 pf-u-pb-0" + className="pf-v5-u-pl-0 pf-v5-u-pt-0 pf-v5-u-pb-0" > {activationKeyInfo.body?.additionalRepositories?.length}{' '} repositories diff --git a/src/Components/CreateImageWizard/steps/Registration/ActivationKeysList.tsx b/src/Components/CreateImageWizard/steps/Registration/ActivationKeysList.tsx index 25e9c666..38c31804 100644 --- a/src/Components/CreateImageWizard/steps/Registration/ActivationKeysList.tsx +++ b/src/Components/CreateImageWizard/steps/Registration/ActivationKeysList.tsx @@ -76,7 +76,7 @@ export const PopoverActivation = () => { variant="plain" aria-label="Activation key popover" aria-describedby="subscription-activation-key" - className="pf-u-pl-sm pf-u-pt-0 pf-u-pb-0 pf-u-pr-0" + className="pf-v5-u-pl-sm pf-v5-u-pt-0 pf-v5-u-pb-0 pf-v5-u-pr-0" > diff --git a/src/Components/CreateImageWizard/steps/Registration/Registration.tsx b/src/Components/CreateImageWizard/steps/Registration/Registration.tsx index e017e6e0..69cace8a 100644 --- a/src/Components/CreateImageWizard/steps/Registration/Registration.tsx +++ b/src/Components/CreateImageWizard/steps/Registration/Registration.tsx @@ -48,7 +48,7 @@ const InsightsPopover = () => { > diff --git a/src/Components/CreateImageWizard/steps/Review/ReviewStep.tsx b/src/Components/CreateImageWizard/steps/Review/ReviewStep.tsx index 02985504..d91be19b 100644 --- a/src/Components/CreateImageWizard/steps/Review/ReviewStep.tsx +++ b/src/Components/CreateImageWizard/steps/Review/ReviewStep.tsx @@ -105,7 +105,7 @@ const Review = ({ snapshottingEnabled }: { snapshottingEnabled: boolean }) => { data-testid={testId} component="span" onClick={() => revisitStep(stepId)} - className="pf-u-p-0 pf-u-font-weight-bold" + className="pf-v5-u-p-0 pf-v5-u-font-weight-bold" isInline > Revisit step @@ -123,7 +123,7 @@ const Review = ({ snapshottingEnabled }: { snapshottingEnabled: boolean }) => { @@ -225,7 +225,7 @@ export const TargetEnvAWSList = () => { Image type @@ -267,7 +267,7 @@ export const TargetEnvGCPList = () => { Image type @@ -330,7 +330,7 @@ export const TargetEnvAzureList = () => { Image type @@ -387,7 +387,7 @@ export const TargetEnvOciList = () => { Object Storage URL @@ -405,7 +405,7 @@ export const TargetEnvOtherList = () => { Image type @@ -485,7 +485,7 @@ export const ContentList = ({ <> Repository snapshot @@ -509,7 +509,7 @@ export const ContentList = ({ @@ -615,7 +615,7 @@ export const RegisterLaterList = () => { Registration type @@ -644,7 +644,7 @@ export const RegisterNowList = () => { Registration type @@ -708,7 +708,7 @@ export const DetailsList = () => { <> Blueprint name @@ -721,7 +721,7 @@ export const DetailsList = () => { <> Description @@ -747,7 +747,7 @@ export const FirstBootList = () => { First boot script diff --git a/src/Components/ImagesTable/EmptyState.tsx b/src/Components/ImagesTable/EmptyState.tsx index 148c44ae..a5996b4c 100644 --- a/src/Components/ImagesTable/EmptyState.tsx +++ b/src/Components/ImagesTable/EmptyState.tsx @@ -99,7 +99,7 @@ const EmptyImagesTable = () => { iconPosition="right" isInline href={CREATING_IMAGES_WITH_IB_SERVICE_URL} - className="pf-u-pt-md" + className="pf-v5-u-pt-md" > Image builder for RPM-DNF documentation diff --git a/src/Components/ImagesTable/ImageDetails.tsx b/src/Components/ImagesTable/ImageDetails.tsx index efae389a..f735be8d 100644 --- a/src/Components/ImagesTable/ImageDetails.tsx +++ b/src/Components/ImagesTable/ImageDetails.tsx @@ -40,7 +40,7 @@ const SourceNotFoundPopover = () => { @@ -63,7 +63,7 @@ const SourceNotFoundPopover = () => { } > - @@ -140,8 +140,10 @@ export const AwsDetails = ({ compose }: AwsDetailsPropTypes) => { return ( <> -
Build Information
- +
+ Build Information +
+ UUID @@ -190,7 +192,7 @@ export const AwsDetails = ({ compose }: AwsDetailsPropTypes) => { <>
-
+
Cloud Provider Identifiers
@@ -229,8 +231,10 @@ export const AzureDetails = ({ compose }: AzureDetailsPropTypes) => { return ( <> -
Build Information
- +
+ Build Information +
+ UUID @@ -264,10 +268,10 @@ export const AzureDetails = ({ compose }: AzureDetailsPropTypes) => {
-
+
Cloud Provider Identifiers
- + Image name @@ -314,8 +318,10 @@ export const GcpDetails = ({ compose }: GcpDetailsPropTypes) => { return ( <> -
Build Information
- +
+ Build Information +
+ UUID @@ -351,10 +357,10 @@ export const GcpDetails = ({ compose }: GcpDetailsPropTypes) => { )}
-
+
Cloud Provider Identifiers
- + Image name @@ -393,8 +399,10 @@ export const OciDetails = ({ compose }: OciDetailsPropTypes) => { return ( <> -
Build Information
- +
+ Build Information +
+ UUID @@ -414,10 +422,10 @@ export const OciDetails = ({ compose }: OciDetailsPropTypes) => {
-
+
Cloud Provider Identifiers
- + Object Storage URL @@ -445,8 +453,10 @@ type AwsS3DetailsPropTypes = { export const AwsS3Details = ({ compose }: AwsS3DetailsPropTypes) => { return ( <> -
Build Information
- +
+ Build Information +
+ UUID diff --git a/src/Components/ImagesTable/ImagesTable.tsx b/src/Components/ImagesTable/ImagesTable.tsx index 4405be56..f8ec8220 100644 --- a/src/Components/ImagesTable/ImagesTable.tsx +++ b/src/Components/ImagesTable/ImagesTable.tsx @@ -229,7 +229,7 @@ const ImagesTable = () => { ); })} - + { iconPosition="right" // TO DO update the link after documentation is up href={FILE_SYSTEM_CUSTOMIZATION_URL} - className="pf-u-pl-0" + className="pf-v5-u-pl-0" > Read more about launching OCI images @@ -325,7 +325,7 @@ export const OciInstance = ({ compose, isExpired }: OciInstancePropTypes) => { > } > - diff --git a/src/Components/LandingPage/LandingPage.scss b/src/Components/LandingPage/LandingPage.scss index e46af229..1dfb6fa0 100644 --- a/src/Components/LandingPage/LandingPage.scss +++ b/src/Components/LandingPage/LandingPage.scss @@ -1,13 +1,13 @@ .pf-c-form__group-label-help { - color: var(--pf-global--icon--Color--light); + color: var(--pf-v5-global--icon--Color--light); } .pf-c-form__group-label-help:active { - color: var(--pf-global--icon--Color--dark); + color: var(--pf-v5-global--icon--Color--dark); } .expand-section { - background-color: var(--pf-global--palette--white); + background-color: var(--pf-v5-global--palette--white); } .sidebar-panel { diff --git a/src/Components/LandingPage/Quickstarts.tsx b/src/Components/LandingPage/Quickstarts.tsx index f9148e89..72a07c77 100644 --- a/src/Components/LandingPage/Quickstarts.tsx +++ b/src/Components/LandingPage/Quickstarts.tsx @@ -13,13 +13,13 @@ export const Quickstarts = () => { return ( setShowHint(val)} isExpanded={showHint} displaySize="lg" > -

+

-

+

-

+

-

+

diff --git a/src/Components/ShareImageModal/RegionsSelect.tsx b/src/Components/ShareImageModal/RegionsSelect.tsx index 6514b7dd..98ca12be 100644 --- a/src/Components/ShareImageModal/RegionsSelect.tsx +++ b/src/Components/ShareImageModal/RegionsSelect.tsx @@ -224,7 +224,7 @@ const RegionsSelect = ({ composeId, handleClose }: RegionsSelectPropTypes) => {