particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CreateImageWizard: Get all matching packages from package search

Browse source 
When searching for a package, all matching packages are now returned. First an
attempt is made using the api's default limit and if there are more
matching packages than the default limit a second request is made with
an increased limit. To facilitate this, api.getPackages() now accepts an
optional limit parameter. Retrieving all matching packages is necessary
because of the sorting logic.
This commit is contained in:
lucasgarfield 2022-02-22 14:35:05 +01:00 • committed by Lucas Garfield
parent 7ec9047140
commit e8e7329bf6
3 changed files with 57 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

39
src/test/Components/CreateImageWizard/CreateImageWizard.test.js
View file

@ -28,7 +28,7 @@ function verifyCancelButton(cancel, history) {
// packages
const mockPkgResult = {
meta: { count: 100 },
meta: { count: 3 },
links: { first: '', last: '' },
data: [
{
@ -49,6 +49,22 @@ const mockPkgResult = {
]
};
const mockPkgResultPartial = {
meta: { count: 132 },
links: { first: '', last: '' },
data: new Array(100).fill().map((_, i) => {
return { name: 'testPkg-' + i, summary: 'test package summary', version: '1.0' };
})
};
const mockPkgResultAll = {
meta: { count: 132 },
links: { first: '', last: '' },
data: new Array(132).fill().map((_, i) => {
return { name: 'testPkg-' + i, summary: 'test package summary', version: '1.0' };
})
};
const mockPkgResultEmpty = {
meta: { count: 0 },
links: { first: '', last: '' },
@ -731,6 +747,27 @@ describe('Step Packages', () => {
expect(chosenPackagesItems).toHaveLength(1);
within(chosenPackagesList).getByRole('option', { name: /testPkg test package summary/ });
});
test('should get all packages, regardless of api default limit', async () => {
await setUp();
const searchbox = screen.getAllByRole('textbox')[0]; // searching by id doesn't update the input ref
searchbox.click();
const getPackages = jest
.spyOn(api, 'getPackages')
.mockImplementation((distribution, architecture, search, limit) => {
return limit ? Promise.resolve(mockPkgResultAll) : Promise.resolve(mockPkgResultPartial);
});
await searchForAvailablePackages(searchbox, 'testPkg');
expect(getPackages).toHaveBeenCalledTimes(2);
const availablePackagesList = screen.getByTestId('available-pkgs-list');
const availablePackagesItems = within(availablePackagesList).getAllByRole('option');
expect(availablePackagesItems).toHaveLength(132);
});
});
describe('Step Review', () => {