particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Wizard: Make AWS sources select scrollable in modal

Browse source 
There is a bug in Patternfly that causes 'pop out' selects (those that
use the menuAppendTo="parent" prop) to be rendered underneat the wizard
footer.

Until this is patched in Patternfly, we will have to live with
suboptimal select menus that scroll inside the modal.
This commit is contained in:
lucasgarfield 2023-05-04 14:41:55 +02:00 • committed by Lucas Garfield
parent c581903745
commit f1f544daec
2 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Components/CreateImageWizard/formComponents/AWSSourcesSelect.js
View file

@ -78,8 +78,6 @@ export const AWSSourcesSelect = ({
isOpen={isOpen}
placeholderText="Select source"
typeAheadAriaLabel="Select source"
menuAppendTo="parent"
maxHeight="25rem"
isDisabled={!isSuccess}
>
{isSuccess &&

26
src/test/Components/CreateImageWizard/CreateImageWizard.beta.test.js
View file

@ -164,7 +164,13 @@ describe('Step Upload to AWS', () => {
test('validation works', async () => {
setUp();
expect(getNextButton()).toHaveClass('pf-m-disabled');
// jsdom seems to render the next button differently than the browser. The
// next button is enabled briefly during the test. This does not occur in
// the browser. Using findByRole instead of getByRole to get the next
// button allows us to capture its 'final' state.
expect(await screen.findByRole('button', { name: /Next/ })).toHaveClass(
'pf-m-disabled'
);
await user.click(
screen.getByRole('radio', { name: /manually enter an account id\./i })
@ -283,9 +289,9 @@ describe('Step Packages', () => {
getNextButton().click();
// aws step
screen
.getByRole('radio', { name: /manually enter an account id\./i })
.click();
await user.click(
screen.getByRole('radio', { name: /manually enter an account id\./i })
);
await user.type(screen.getByTestId('aws-account-id'), '012345678901');
getNextButton().click();
// skip registration
@ -545,9 +551,9 @@ describe('Step Custom repositories', () => {
getNextButton().click();
// aws step
screen
.getByRole('radio', { name: /manually enter an account id\./i })
.click();
await user.click(
screen.getByRole('radio', { name: /manually enter an account id\./i })
);
await user.type(screen.getByTestId('aws-account-id'), '012345678901');
getNextButton().click();
// skip registration
@ -654,9 +660,9 @@ describe('Click through all steps', () => {
await user.click(screen.getByTestId('checkbox-image-installer'));
screen.getByRole('button', { name: /Next/ }).click();
screen
.getByRole('radio', { name: /manually enter an account id\./i })
.click();
await user.click(
screen.getByRole('radio', { name: /manually enter an account id\./i })
);
await user.type(screen.getByTestId('aws-account-id'), '012345678901');
screen.getByRole('button', { name: /Next/ }).click();