particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

V2Wizard: Move OSCAP alert outside of OscapProfileInformation

Browse source 
This moves the "Additional customizations" alert outside of OscapProfileInformation which ensures it is not shown in the Oscap expandable on the Review step.

User can see the added customisations in the individual expandables, making the alert non-actionable extra information.
This commit is contained in:
regexowl 2024-03-01 16:46:40 +01:00 • committed by Lucas Garfield
parent c60e45cd4d
commit f9350956f7
2 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/Components/CreateImageWizardV2/steps/Oscap/Oscap.tsx
View file

@ -285,10 +285,24 @@ const OScapSelectOption = ({
};
export const Oscap = () => {
const oscapProfile = useAppSelector((state) => selectProfile(state));
return (
<>
<ProfileSelector />
<OscapProfileInformation />
{oscapProfile && (
<Alert
variant="info"
isInline
isPlain
title="Additional customizations"
>
Selecting an OpenSCAP profile will cause the appropriate packages,
file system configuration, kernel arguments, and services to be added
to your image.
</Alert>
)}
</>
);
};

12
src/Components/CreateImageWizardV2/steps/Oscap/OscapProfileInformation.tsx
View file

@ -1,7 +1,6 @@
import React from 'react';
import {
Alert,
CodeBlock,
CodeBlockCode,
Spinner,
@ -116,17 +115,6 @@ export const OscapProfileInformation = (): JSX.Element => {
</TextListItem>
</TextList>
</TextContent>
<Alert
variant="info"
isInline
isPlain
title="Additional customizations"
>
Selecting an OpenSCAP profile will cause the appropriate packages,
file system configuration, kernel arguments, and services to be
added to your image.
</Alert>
</>
)}
</>