particle-os/debian-image-builder-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: Safeguard first setUp() in .test and .azure against early exit

Browse source 
The "Step Image output - clicking Next loads Upload to AWS" and "Step Upload to Azure - clicking Next loads Registration" were sometimes returning the "Warning: An update to <element> inside a test was not wrapped in act(...)" error.

This seems to have been caused by an early exit in the `setUp()` function in the first `describe` block.
Safeguards were put in place to fix this behaviour.

As this error didn't occur every time, testing the updates was not easy. This current fix passed the threshold of ten successful runs of `npm run test`.
This commit is contained in:
regexowl 2023-08-29 12:46:47 +02:00 • committed by Lucas Garfield
parent 8a31592ef8
commit ff0eb304bf
2 changed files with 25 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/test/Components/CreateImageWizard/CreateImageWizard.test.js
View file

@ -136,22 +136,19 @@ describe('Create Image Wizard', () => {
describe('Step Image output', () => {
const user = userEvent.setup();
const setUp = () => {
const setUp = async () => {
({ router } = renderCustomRoutesWithReduxRouter('imagewizard', {}, routes));
// select aws as upload destination
user.click(screen.getByTestId('upload-aws'));
await user.click(await screen.findByTestId('upload-aws'));
// load from sidebar
user.click(
screen.getByRole('button', {
name: 'Image output',
})
expect(screen.getByRole('heading', { level: 1 })).toHaveTextContent(
'Image output'
);
};
test('clicking Next loads Upload to AWS', async () => {
setUp();
await setUp();
await clickNext();
@ -160,14 +157,14 @@ describe('Step Image output', () => {
});
test('clicking Cancel loads landing page', async () => {
setUp();
await setUp();
await clickNext();
await verifyCancelButton(router);
});
test('target environment is required', () => {
setUp();
test('target environment is required', async () => {
await setUp();
const destination = screen.getByTestId('target-select');
const required = within(destination).getByText('*');
@ -176,7 +173,8 @@ describe('Step Image output', () => {
});
test('selecting and deselecting a tile disables the next button', async () => {
setUp();
await setUp();
const nextButton = await getNextButton();
const awsTile = screen.getByTestId('upload-aws');
// this has already been clicked once in the setup function
@ -190,11 +188,11 @@ describe('Step Image output', () => {
user.click(azureTile); // select
user.click(azureTile); // deselect
expect(await getNextButton()).toBeDisabled();
await waitFor(() => expect(nextButton).toBeDisabled());
});
test('expect only RHEL releases before expansion', async () => {
setUp();
await setUp();
const releaseMenu = screen.getByRole('button', {
name: /options menu/i,
@ -215,7 +213,7 @@ describe('Step Image output', () => {
});
test('expect all releases after expansion', async () => {
setUp();
await setUp();
const releaseMenu = screen.getByRole('button', {
name: /options menu/i,
@ -246,7 +244,7 @@ describe('Step Image output', () => {
});
test('CentOS acknowledgement appears', async () => {
setUp();
await setUp();
const releaseMenu = screen.getByRole('button', {
name: /options menu/i,