This commit simplifies and tidies up the shared ImageBuilderHeader
component by removing some of the `Flex` and `FlexItem` components.
Instead we can use the `actionComponents` from the `PageHeader`
component which takes care of some of the flex logic for us.
If the reset button is clicked, there is a glitch that shows error state
for a moment. This commit removes the glitch by setting the snapshot
date even for invalid values, and removes the workaround that was
previously added.
Tiles are being deprecated in PatternFly. This commit switches from
tiles to cards for the Target Environments in the CreateImageWizard.
The keyboard test had to be removed since cards don't have a keydown
event.
Recently the wizard has started rendering such that its vertical height
matches the height of its body – and therefore only occupies some
fraction of the page’s vertical space for many steps. The desired
behavior is for its footer to be fixed at the bottom of the viewport.
Specifying the page section type prop as ‘wizard’ resolves the issue.
This is the pattern used in the Patternfly documentation for in-page
wizards. See here:
https://www.patternfly.org/components/wizard/react-demos#in-page
Using CSS to adjust Patternfly component rendering is an antipattern.
More custom CSS means more time spent troubleshooting rendering issues.
Custom CSS related to rendering of the wizard has been removed.
There is still an annoying issue. The body of the wizard is not
scrollable and will overflow. This is counter to the Patternfly
examples. There doesn’t seem to be any CSS in Image Builder that would
cause this to occur. Perhaps the problem is somehow inherited from
Insights Chrome? In any case, this will require further investigation.
The error for invalid user groups was not previously rendered on import. This fixes the issue and adds an import test to check that the error messages for all user fields get correctly rendered.
User password gets redacted from a blueprint, meaning if there was any password set, it does not render on import.
Previously a placeholder was rendered as a value of password, making the value not editable. This renders the password indication as a placeholder text, solving the issue.
This was a bug that was looking for incorrect path in files. We do not
want to treat cmd as a secret, we decided to expose it, so this was just
an inconvenience.
