The tests output contained following warning:
```
console.warn
Th: Table headers must have an accessible name. If the Th is intended to be visually empty, pass in screenReaderText. If the Th contains only non-text, interactive content such as a checkbox or expand toggle, pass in an aria-label.
```
This fixes the warning by adding an `aria-label` to every empty table heading cell.
227 lines
6.1 KiB
TypeScript
227 lines
6.1 KiB
TypeScript
import React, { useRef, useState } from 'react';
|
|
|
|
import { Popover, TextContent, Text, Button } from '@patternfly/react-core';
|
|
import { HelpIcon } from '@patternfly/react-icons';
|
|
import styles from '@patternfly/react-styles/css/components/Table/table';
|
|
import {
|
|
Table,
|
|
Th,
|
|
Thead,
|
|
Tbody,
|
|
Tr,
|
|
TrProps,
|
|
TbodyProps,
|
|
} from '@patternfly/react-table';
|
|
|
|
import { Row } from './FileSystemConfiguration';
|
|
|
|
import { useAppDispatch, useAppSelector } from '../../../../store/hooks';
|
|
import {
|
|
changePartitionOrder,
|
|
selectPartitions,
|
|
} from '../../../../store/wizardSlice';
|
|
|
|
export const MinimumSizePopover = () => {
|
|
return (
|
|
<Popover
|
|
maxWidth="30rem"
|
|
bodyContent={
|
|
<TextContent>
|
|
<Text>
|
|
Image Builder may extend this size based on requirements, selected
|
|
packages, and configurations.
|
|
</Text>
|
|
</TextContent>
|
|
}
|
|
>
|
|
<Button
|
|
variant="plain"
|
|
aria-label="File system configuration info"
|
|
aria-describedby="file-system-configuration-info"
|
|
className="pf-u-pl-sm pf-u-pt-0 pf-u-pb-0"
|
|
>
|
|
<HelpIcon />
|
|
</Button>
|
|
</Popover>
|
|
);
|
|
};
|
|
|
|
const FileSystemTable = () => {
|
|
const [draggedItemId, setDraggedItemId] = useState<string | null>(null);
|
|
const [draggingToItemIndex, setDraggingToItemIndex] = useState<number | null>(
|
|
null
|
|
);
|
|
const [isDragging, setIsDragging] = useState(false);
|
|
const [tempItemOrder, setTempItemOrder] = useState<string[]>([]);
|
|
|
|
const bodyRef = useRef<HTMLTableSectionElement>(null);
|
|
const partitions = useAppSelector(selectPartitions);
|
|
const itemOrder = partitions.map((partition) => partition.id);
|
|
const dispatch = useAppDispatch();
|
|
const isValidDrop = (
|
|
evt: React.DragEvent<HTMLTableSectionElement | HTMLTableRowElement>
|
|
) => {
|
|
const ulRect = bodyRef.current?.getBoundingClientRect();
|
|
if (!ulRect) return false;
|
|
return (
|
|
evt.clientX > ulRect.x &&
|
|
evt.clientX < ulRect.x + ulRect.width &&
|
|
evt.clientY > ulRect.y &&
|
|
evt.clientY < ulRect.y + ulRect.height
|
|
);
|
|
};
|
|
|
|
const onDragStart: TrProps['onDragStart'] = (evt) => {
|
|
evt.dataTransfer.effectAllowed = 'move';
|
|
evt.dataTransfer.setData('text/plain', evt.currentTarget.id);
|
|
const draggedItemId = evt.currentTarget.id;
|
|
|
|
evt.currentTarget.classList.add(styles.modifiers.ghostRow);
|
|
evt.currentTarget.setAttribute('aria-pressed', 'true');
|
|
|
|
setDraggedItemId(draggedItemId);
|
|
setIsDragging(true);
|
|
};
|
|
|
|
const onDragCancel = () => {
|
|
const children = bodyRef.current?.children;
|
|
if (children) {
|
|
Array.from(children).forEach((el) => {
|
|
el.classList.remove(styles.modifiers.ghostRow);
|
|
el.setAttribute('aria-pressed', 'false');
|
|
});
|
|
}
|
|
setDraggedItemId(null);
|
|
setDraggingToItemIndex(null);
|
|
setIsDragging(false);
|
|
};
|
|
|
|
const onDragLeave: TbodyProps['onDragLeave'] = (evt) => {
|
|
if (!isValidDrop(evt)) {
|
|
move(itemOrder);
|
|
setDraggingToItemIndex(null);
|
|
}
|
|
};
|
|
|
|
const onDrop: TrProps['onDrop'] = (evt) => {
|
|
if (isValidDrop(evt)) {
|
|
dispatch(changePartitionOrder(tempItemOrder));
|
|
} else {
|
|
onDragCancel();
|
|
}
|
|
};
|
|
|
|
const onDragOver: TbodyProps['onDragOver'] = (evt) => {
|
|
evt.preventDefault();
|
|
|
|
const curListItem = (evt.target as HTMLTableSectionElement).closest('tr');
|
|
if (
|
|
!curListItem ||
|
|
!bodyRef.current?.contains(curListItem) ||
|
|
curListItem.id === draggedItemId
|
|
) {
|
|
return null;
|
|
} else {
|
|
const dragId = curListItem.id;
|
|
const newDraggingToItemIndex = Array.from(
|
|
bodyRef.current.children
|
|
).findIndex((item) => item.id === dragId);
|
|
if (newDraggingToItemIndex !== draggingToItemIndex && draggedItemId) {
|
|
const tempItemOrder = moveItem(
|
|
[...itemOrder],
|
|
draggedItemId,
|
|
newDraggingToItemIndex
|
|
);
|
|
move(tempItemOrder);
|
|
setDraggingToItemIndex(newDraggingToItemIndex);
|
|
setTempItemOrder(tempItemOrder);
|
|
}
|
|
}
|
|
};
|
|
|
|
const onDragEnd: TrProps['onDragEnd'] = (evt) => {
|
|
const target = evt.target as HTMLTableRowElement;
|
|
target.classList.remove(styles.modifiers.ghostRow);
|
|
target.setAttribute('aria-pressed', 'false');
|
|
setDraggedItemId(null);
|
|
setDraggingToItemIndex(null);
|
|
setIsDragging(false);
|
|
};
|
|
|
|
const moveItem = (arr: string[], i1: string, toIndex: number) => {
|
|
const fromIndex = arr.indexOf(i1);
|
|
if (fromIndex === toIndex) {
|
|
return arr;
|
|
}
|
|
const temp = arr.splice(fromIndex, 1);
|
|
arr.splice(toIndex, 0, temp[0]);
|
|
|
|
return arr;
|
|
};
|
|
|
|
const move = (itemOrder: string[]) => {
|
|
const ulNode = bodyRef.current;
|
|
if (!ulNode) {
|
|
return;
|
|
}
|
|
const nodes = Array.from(ulNode.children);
|
|
if (nodes.map((node) => node.id).every((id, i) => id === itemOrder[i])) {
|
|
return;
|
|
}
|
|
while (ulNode.firstChild) {
|
|
ulNode.removeChild(ulNode.lastChild as Node);
|
|
}
|
|
|
|
itemOrder.forEach((id) => {
|
|
const node = nodes.find((n) => n.id === id);
|
|
if (node) {
|
|
ulNode.appendChild(node);
|
|
}
|
|
});
|
|
};
|
|
|
|
return (
|
|
<Table
|
|
className={isDragging ? styles.modifiers.dragOver : ''}
|
|
ouiaId="partition_table_v2"
|
|
aria-label="File system table"
|
|
variant="compact"
|
|
data-testid="fsc-table"
|
|
>
|
|
<Thead>
|
|
<Tr>
|
|
<Th aria-label="Drag mount point" />
|
|
<Th>Mount point</Th>
|
|
<Th aria-label="Suffix"></Th>
|
|
<Th>Type</Th>
|
|
<Th>
|
|
Minimum size <MinimumSizePopover />
|
|
</Th>
|
|
<Th aria-label="Unit" />
|
|
<Th aria-label="Remove mount point" />
|
|
</Tr>
|
|
</Thead>
|
|
|
|
<Tbody
|
|
onDragOver={onDragOver}
|
|
onDrop={onDragOver}
|
|
onDragLeave={onDragLeave}
|
|
ref={bodyRef}
|
|
data-testid="file-system-configuration-tbody"
|
|
>
|
|
{partitions &&
|
|
partitions.map((partition) => (
|
|
<Row
|
|
onDrop={onDrop}
|
|
onDragEnd={onDragEnd}
|
|
onDragStart={onDragStart}
|
|
key={partition.id}
|
|
partition={partition}
|
|
/>
|
|
))}
|
|
</Tbody>
|
|
</Table>
|
|
);
|
|
};
|
|
|
|
export default FileSystemTable;
|