This commit modernizes the Redux store to bring it in line with the current recommended best practices/patterns. It is possible because of a recent previous commit that added Redux Toolkit as a dependency. For detailed information on what modern Redux entails, see the Redux docs: https://redux.js.org/introduction/getting-started#learn-modern-redux-livestream Practically speaking, this means a huge reduction in boilerplate code. Maintaining and extending the code will be much easier. All Redux logic is now encapsulated by 'slices'. Reducers are defined in the slices, and action creators and action types are generated automatically. Redux Toolkit includes Immer, which greatly simplifies writing reducer logic much simpler - state updates in Redux must be immutable, but working with Javascript objects in an immutable fashion is clumsy, requiring gratuitious use of the spread ... operator. With Immer, the state can be updated as if mutable updates were allowed. Reducer logic has been changed to take advantage of this in this commit. This commit also removes a large amount of unused code. Fingers crossed that nothing breaks. The tests do pass, afterall... One other minor change... composesGet was renamed to fetchComposes and composeGetStatus was renamed to fetchComposeStatus. This is in line with the Redux documentation examples. |
||
|---|---|---|
| .github | ||
| .travis | ||
| config | ||
| devel | ||
| distribution | ||
| schutzbot | ||
| src | ||
| .eslintrc.yml | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .stylelintrc.json | ||
| .travis.yml | ||
| babel.config.js | ||
| codecov.yml | ||
| LICENSE | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
image-builder-frontend
Frontend Development
To develop the frontend you can use a proxy to run image-builder-frontend locally against the chrome and backend at console.redhat.com.
Working against the production environment is preferred, as any work can be released without worrying if a feature from stage has been released yet.
Nodejs and npm version
Make sure you have npm@7 and node 15+ installed. If you need multiple versions of nodejs check out nvm.
Webpack proxy
-
run
npm ci -
run
npm run prod-beta. This command uses a prod-beta env by default. Configure your environment by theenvattribute indev.webpack.config.js. -
Secondly redirect a few
prod.foo.redhat.comto localhost, if this has not been done already.
echo "127.0.0.1 prod.foo.redhat.com" >> /etc/hosts
- open browser at
https://prod.foo.redhat.com:1337/beta/insights/image-builder
Webpack proxy (staging) -- Runs with image-builder's stage deployment
-
run
npm ci -
run
npm run stage-beta. This command uses a stage-beta env by default. Configure your environment by theenvattribute indev.webpack.config.js. -
Secondly redirect a few
stage.foo.redhat.comto localhost, if this has not been done already.
echo "127.0.0.1 stage.foo.redhat.com" >> /etc/hosts
- open browser at
https://stage.foo.redhat.com:1337/beta/insights/image-builder
Insights proxy (deprecated)
-
Clone the insights proxy: https://github.com/RedHatInsights/insights-proxy
-
Setting up the proxy
Choose a runner (podman or docker), and point the SPANDX_CONFIG variable to
profile/local-frontend.jsincluded in image-builder-frontend.sudo insights-proxy/scripts/patch-etc-hosts.sh export RUNNER="podman" export SPANDX_CONFIG=$PATH_TO/image-builder-frontend/profiles/local-frontend.js sudo -E insights-proxy/scripts/run.sh -
Starting up image-builder-frontend
In the image-builder-frontend checkout directory
npm install npm start
The UI should be running on https://prod.foo.redhat.com:1337/beta/insights/image-builder/landing. Note that this requires you to have access to either production or stage (plus VPN and proxy config) of insights.
Backend Development
To develop both the frontend and the backend you can again use the proxy to run both the frontend and backend locally against the chrome at cloud.redhat.com. For instructions see devel/README.md.
Style Guidelines
This project uses eslint's recommended styling guidelines. These rules can be found here: https://eslint.org/docs/rules/
Test Guidelines
Testing is done using React Testing Library. All UI contributions must also include a new test or update an existing test in order to maintain code coverage.
Tests can be run with
npm run test
These tests will also be run in our Travis CI when a PR is opened.