Resolves #466. The default behavior for the DDF Wizard is to either advance to the next step or submit the form when the ENTER is pressed. This is inappropriate for complex forms that contain many different types of elements that are typically interacted with using ENTER. For instance, the default behavior when a link is focused and ENTER is pressed is not to open the link in a browser but to advance or submit the form. This commit overrides the default behavior by passing an onKeyDown prop to the wizard which calls a custom onKeyDown function. The new custom function does not define any behavior for when ENTER is pressed, but does recreate DDF's default ESCAPE behavior, which is to close the modal. |
||
|---|---|---|
| .github | ||
| .travis | ||
| config | ||
| devel | ||
| distribution | ||
| src | ||
| .babelrc | ||
| .eslintrc.yml | ||
| .gitignore | ||
| .stylelintrc.json | ||
| .travis.yml | ||
| codecov.yml | ||
| LICENSE | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
image-builder-frontend
Frontend Development
To develop the frontend you can use a proxy to run image-builder-frontend locally against the chrome and backend at console.redhat.com.
Working against the production environment is preferred, as any work can be released without worrying if a feature from stage has been released yet.
Nodejs and npm version
Make sure you have npm@7 and node 15+ installed. If you need multiple versions of nodejs check out nvm.
Webpack proxy
-
run
npm ci -
run
npm run start:proxy:beta. This command uses a prod-beta env by default. Configure your environment by theenvattribute indev.webpack.config.js. -
open browser at
https://prod.foo.redhat.com:1337/beta/insights/image-builder
Webpack proxy (staging) -- Runs with image-builder's stage deployment
-
run
npm ci -
run
npm run stage. This command uses a stage-beta env by default. Configure your environment by theenvattribute indev.webpack.config.js. -
open browser at
https://stage.foo.redhat.com:1337/beta/insights/image-builder
Insights proxy (deprecated)
-
Clone the insights proxy: https://github.com/RedHatInsights/insights-proxy
-
Setting up the proxy
Choose a runner (podman or docker), and point the SPANDX_CONFIG variable to
profile/local-frontend.jsincluded in image-builder-frontend.sudo insights-proxy/scripts/patch-etc-hosts.sh export RUNNER="podman" export SPANDX_CONFIG=$PATH_TO/image-builder-frontend/profiles/local-frontend.js sudo -E insights-proxy/scripts/run.sh -
Starting up image-builder-frontend
In the image-builder-frontend checkout directory
npm install npm start
The UI should be running on https://prod.foo.redhat.com:1337/beta/insights/image-builder/landing. Note that this requires you to have access to either production or stage (plus VPN and proxy config) of insights.
Backend Development
To develop both the frontend and the backend you can again use the proxy to run both the frontend and backend locally against the chrome at cloud.redhat.com. For instructions see devel/README.md.
Style Guidelines
This project uses eslint's recommended styling guidelines. These rules can be found here: https://eslint.org/docs/rules/
Test Guidelines
Testing is done using React Testing Library. All UI contributions must also include a new test or update an existing test in order to maintain code coverage.
Tests can be run with
npm run test
These tests will also be run in our Travis CI when a PR is opened.