From 039fc6b618f8f5eebc5b082d15f1da2276917c57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Budai?= Date: Wed, 23 Mar 2022 15:13:18 +0100 Subject: [PATCH] test/builder: drop misleading quotes from config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit configparser treats quotes literally: client_id = "koji" translates to the following python string: '"koji"' This doesn't matter in the test because the oauth mock from osbuild-composer actually ignores the credentials and return the token in every case. But if you want to take this config as an example, you will probably put the credentials automatically inside the quotes which will not work because a real oauth server will refuse the client ID surrounded by quotes. Note that .conf works different than .toml: TOML requires to have strings in quotes. Yeah, consistency. 🤷 --- test/container/builder/osbuild-koji.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/container/builder/osbuild-koji.conf b/test/container/builder/osbuild-koji.conf index 0539da7..eeadb4f 100644 --- a/test/container/builder/osbuild-koji.conf +++ b/test/container/builder/osbuild-koji.conf @@ -3,8 +3,8 @@ server = https://composer/ ssl_verify = /share/client-ca.pem [composer:oauth] -client_id = "koji" -client_secret = "koji" +client_id = koji +client_secret = koji token_url = https://composer:8081/token [koji]