particle-os/debian-koji-osbuild
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugin/cli: eager check of target input

Browse source 
Check the target with name exists and has a destination tag, so
we can abort early.
This commit is contained in:
Christian Kellner 2020-09-09 15:56:35 +02:00
parent 3934382337
commit 3f5de8a68d
1 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
plugins/cli/osbuild.py
View file

@ -1,4 +1,5 @@
"""osbild koji command line client integration""" """osbild koji command line client integration"""
import koji
import koji_cli.lib as kl import koji_cli.lib as kl
from koji.plugin import export_cli from koji.plugin import export_cli
from koji_cli.lib import _ from koji_cli.lib import _
@ -36,6 +37,19 @@ def parse_args(argv):
return opts return opts
def check_target(session, name: str):
"""Check the target with name exists and has a destination tag"""
target = session.getBuildTarget(name)
if not target:
raise koji.GenericError(_("Unknown build target: %s" % name))
tag = session.getTag(target['dest_tag'])
if not tag:
raise koji.GenericError(_("Unknown destination tag: %s" %
target['dest_tag_name']))
@export_cli @export_cli
def handle_osbuild_image(options, session, argv): def handle_osbuild_image(options, session, argv):
"[build] Build images via osbuild" "[build] Build images via osbuild"
@ -55,6 +69,9 @@ def handle_osbuild_image(options, session, argv):
if args.repo: if args.repo:
opts["repo"] = ",".join(args.repo) opts["repo"] = ",".join(args.repo)
# Do some early checks to be able to give quick feedback
check_target(session, target)
if not options.quiet: if not options.quiet:
print("name:", name) print("name:", name)
print("version:", version) print("version:", version)