particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR#3145: Deprecated force option in groupPackageListRemove call

Browse source 
Merges #3145
https://pagure.io/koji/pull-request/3145

Fixes: #3131
https://pagure.io/koji/issue/3131
API call groupPackageListRemove never uses force parameter
This commit is contained in:
Tomas Kopecek 2021-12-13 16:38:28 +01:00
commit 0b911ed0c4
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
hub/kojihub.py
View file

@ -1958,7 +1958,7 @@ def _grp_pkg_add(taginfo, grpinfo, pkg_name, block, force, **opts):
insert.execute()
def grp_pkg_remove(taginfo, grpinfo, pkg_name, force=False):
def grp_pkg_remove(taginfo, grpinfo, pkg_name, force=None):
"""Remove package from the list for group-tag
Really this shouldn't be used except in special cases
@ -1971,6 +1971,9 @@ def grp_pkg_remove(taginfo, grpinfo, pkg_name, force=False):
def _grp_pkg_remove(taginfo, grpinfo, pkg_name, force):
"""grp_pkg_remove without permssion checks"""
if force is not None:
logger.warning("force option in groupPackageListRemove call is deprecated and "
"will be removed in 1.30")
tag_id = get_tag_id(taginfo, strict=True)
grp_id = get_group_id(grpinfo, strict=True)
update = UpdateProcessor('group_package_listing', values=locals(),