unit tests

tests/test_cli/test_remove_group_pkg.py

@@ -25,6 +25,9 @@ class TestRemoveGroupPkg(utils.CliTestCase):
 %s: error: {message}
 """ % (self.progname, self.progname)
 
+    def tearDown(self):
+        mock.patch.stopall()
+
     def test_handle_remove_pkg_not_existing_tag(self):
         tag = 'tag'
         package = 'package'
@@ -68,12 +71,17 @@ class TestRemoveGroupPkg(utils.CliTestCase):
     @mock.patch('sys.stderr', new_callable=six.StringIO)
     def test_handle_remove_pkg(self, stderr, stdout):
         tag = 'tag'
-        dsttag = {'name': tag, 'id': 1}
+        tagID = 1
+        dsttag = {'name': tag, 'id': tagID}
         package = 'package'
         group = 'group'
         args = [tag, group, package]
 
         self.session.getTag.return_value = dsttag
+        self.session.getTagGroups.return_value = [
+            {'name': group, 'group_id': 'groupId', 'blocked': False, 'tag_id': tagID,
+             'packagelist': [{'package': package, 'blocked': False, 'tag_id': tagID}]
+            }]
         self.session.groupPackageListRemove.return_value = None
         handle_remove_group_pkg(self.options, self.session, args)
         actual = stderr.getvalue()
@@ -86,24 +94,99 @@ class TestRemoveGroupPkg(utils.CliTestCase):
         self.activate_session_mock.assert_called_once_with(self.session, self.options)
         self.session.getTag.assert_called_once_with(tag)
 
-    @mock.patch('sys.stdout', new_callable=six.StringIO)
-    @mock.patch('sys.stderr', new_callable=six.StringIO)
-    def test_handle_remove_pkg_with_force(self, stderr, stdout):
+    def test_handle_group_not_present(self):
         tag = 'tag'
-        dsttag = {'name': tag, 'id': 1}
+        tagID = 1
+        dsttag = {'name': tag, 'id': tagID}
         package = 'package'
         group = 'group'
-        args = [tag, group, package, '--force']
+        args = [tag, group, package]
 
         self.session.getTag.return_value = dsttag
+        self.session.getTagGroups.return_value = []
         self.session.groupPackageListRemove.return_value = None
-        handle_remove_group_pkg(self.options, self.session, args)
-        actual = stderr.getvalue()
-        expected = ''
-        self.assertMultiLineEqual(actual, expected)
-        actual = stdout.getvalue()
-        expected = ''
-        self.assertMultiLineEqual(actual, expected)
-        # Finally, assert that things were called as we expected.
-        self.activate_session_mock.assert_called_once_with(self.session, self.options)
+
+        self.assert_system_exit(
+            handle_remove_group_pkg,
+            self.options, self.session, args,
+            stderr='Group group is not present in tag tag\n',
+            stdout='',
+            exit_code=1)
+
         self.session.getTag.assert_called_once_with(tag)
+
+    def test_handle_package_not_included(self):
+        tag = 'tag'
+        tagID = 1
+        dsttag = {'name': tag, 'id': tagID}
+        package = 'package'
+        group = 'group'
+        args = [tag, group, package]
+
+        self.session.getTag.return_value = dsttag
+        self.session.getTagGroups.return_value = [
+            {'name': group, 'group_id': 'groupId', 'blocked': False, 'tag_id': tagID,
+             'packagelist': []
+            }]
+        self.session.groupPackageListRemove.return_value = None
+
+        self.assert_system_exit(
+            handle_remove_group_pkg,
+            self.options, self.session, args,
+            stdout='Package package is not included in this group\n',
+            stderr='Invalid parameters\n',
+            exit_code=1)
+
+        self.session.getTag.assert_called_once_with(tag)
+
+    def test_handle_package_blocked(self):
+        tag = 'tag'
+        tagID = 1
+        dsttag = {'name': tag, 'id': tagID}
+        package = 'package'
+        group = 'group'
+        args = [tag, group, package]
+
+        self.session.getTag.return_value = dsttag
+        self.session.getTagGroups.return_value = [
+            {'name': group, 'group_id': 'groupId', 'blocked': False, 'tag_id': tagID,
+             'packagelist': [{'package': package, 'blocked': True, 'tag_id': tagID}]
+            }]
+        self.session.groupPackageListRemove.return_value = None
+
+        self.assert_system_exit(
+            handle_remove_group_pkg,
+            self.options, self.session, args,
+            stdout='Package package is blocked in this group. '
+                   'You could use unblock-group-pkg to unblock it\n',
+            stderr='Invalid parameters\n',
+            exit_code=1)
+
+        self.session.getTag.assert_called_once_with(tag)
+
+    def test_handle_package_inherited(self):
+        tag = 'tag'
+        tagID = 1
+        dsttag = {'name': tag, 'id': tagID}
+        parentID = 20
+        ptag = {'name': 'parent', 'id': parentID}
+        package = 'package'
+        group = 'group'
+        args = [tag, group, package]
+
+        self.session.getTag.side_effect = [dsttag, ptag]
+        self.session.getTagGroups.return_value = [
+            {'name': group, 'group_id': 'groupId', 'blocked': False, 'tag_id': tagID,
+             'packagelist': [{'package': package, 'blocked': False, 'tag_id': parentID}]
+            }]
+        self.session.groupPackageListRemove.return_value = None
+
+        self.assert_system_exit(
+            handle_remove_group_pkg,
+            self.options, self.session, args,
+            stdout='The entry for package package is inherited from parent. You could use block-group-pkg to prevent this\n',
+            stderr='Invalid parameters\n',
+            exit_code=1)
+
+
+# the end