From 1019b3af3533a0e57ba5ff34baf9ecaee08da90d Mon Sep 17 00:00:00 2001
From: Mike McLean <mikem@redhat.com>
Date: Fri, 27 Sep 2024 16:17:32 -0400
Subject: [PATCH] fix store offsets when duplicate tags are present

For context, see https://pagure.io/koji/issue/4200

If an rpm has duplicate tags in a header, Koji would miscalculate the
start of that data store.
---
 koji/__init__.py | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/koji/__init__.py b/koji/__init__.py
index 99667475..44ef330c 100644
--- a/koji/__init__.py
+++ b/koji/__init__.py
@@ -688,6 +688,7 @@ class RawHeader(object):
         data = [_ord(x) for x in self.header[8:12]]
         il = multibyte(data[:4])
         dl = multibyte(data[4:8])
+        self._store = 16 + il * 16
 
         # read the index (starts at offset 16)
         index = {}
@@ -705,12 +706,8 @@ class RawHeader(object):
 
     def dump(self, sig=None):
         print("HEADER DUMP:")
-        # calculate start of store
-        il = len(self.index)
-        store = 16 + il * 16
-        # print("start is: %d" % start)
-        # print("index length: %d" % il)
-        print("Store at offset %d (%0x)" % (store, store))
+        store = self._store
+        print("Store at offset %d (0x%0x)" % (store, store))
         # sort entries by offset, dtype
         # also rearrange: tag, dtype, offset, count -> offset, dtype, tag, count
         order = sorted([(x[2], x[1], x[0], x[3]) for x in six.itervalues(self.index)])
@@ -869,9 +866,7 @@ class RawHeader(object):
     def _getitem(self, dtype, offset, count, decode=None):
         if decode is None:
             decode = self.decode
-        # calculate start of store
-        il = len(self.index)
-        store = 16 + il * 16
+        store = self._store
         pos = store + offset
         if dtype >= 2 and dtype <= 5:
             values = []