particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix typo and extend unit test to cover where it occurred

Browse source
This commit is contained in:
Mike McLean 2019-11-13 14:58:20 -05:00
parent 727de7d953
commit 1344062bdd
2 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hub/kojihub.py
View file

@ -8429,7 +8429,7 @@ class BulkInsertProcessor(object):
def execute(self):
if not self.batch:
self.__one_insert(self.data)
self._one_insert(self.data)
else:
for i in range(0, len(self.data), self.batch):
data = self.data[i:i+self.batch]

17
tests/test_hub/test_insert_processor.py
View file

@ -189,3 +189,20 @@ class TestBulkInsertProcessor(unittest.TestCase):
calls[1][1],
('INSERT INTO sometable (foo) VALUES (%(foo0)s)',
{'foo0': 'bar3'}))
@mock.patch('kojihub.context')
def test_no_batch_execution(self, context):
cursor = mock.MagicMock()
context.cnx.cursor.return_value = cursor
proc = kojihub.BulkInsertProcessor('sometable', data=[{'foo': 'bar1'}], batch=None)
proc.add_record(foo='bar2')
proc.add_record(foo='bar3')
proc.execute()
calls = cursor.execute.mock_calls
# list of (name, positional args, keyword args)
self.assertEquals(len(calls), 1)
self.assertEquals(
calls[0][1],
('INSERT INTO sometable (foo) VALUES (%(foo0)s), (%(foo1)s), (%(foo2)s)',
{'foo0': 'bar1', 'foo1': 'bar2', 'foo2': 'bar3'}))