From 2734d5276fd92aa6388961dc75d545f008b870a7 Mon Sep 17 00:00:00 2001
From: Mike McLean <mikem@redhat.com>
Date: Tue, 19 Aug 2025 13:05:13 -0400
Subject: [PATCH] require lowercase sigkey

---
 kojihub/kojihub.py                 | 4 ++++
 tests/test_hub/test_add_rpm_sig.py | 1 +
 2 files changed, 5 insertions(+)

diff --git a/kojihub/kojihub.py b/kojihub/kojihub.py
index af6e398c..c848bc99 100644
--- a/kojihub/kojihub.py
+++ b/kojihub/kojihub.py
@@ -8332,6 +8332,10 @@ def validate_sigkey_value(sigkey):
     if '/' in sigkey or sigkey.startswith('.'):
         # not allowed because the value is used in a path
         raise koji.GenericError("Invalid sigkey value")
+    if sigkey != sigkey.lower():
+        # we require lowercase because koji has historically forced lowercase for this value
+        # e.g. in query_rpm_sigs
+        raise koji.GenericError("Invalid sigkey value. Must be lowercase")
     verify_name_internal(sigkey)
 
 
diff --git a/tests/test_hub/test_add_rpm_sig.py b/tests/test_hub/test_add_rpm_sig.py
index fcf62b0d..c40067ae 100644
--- a/tests/test_hub/test_add_rpm_sig.py
+++ b/tests/test_hub/test_add_rpm_sig.py
@@ -154,6 +154,7 @@ class TestAddRPMSig(unittest.TestCase):
             'badchar!',
             '.hidden',
             'sub/dir',
+            'hasUPPERcase',
         ]
         for sigkey in badkeys:
             with self.assertRaises(koji.GenericError):