Update py2 tests
Py2 test updates for https://pagure.io/koji/pull-request/4214 Related: https://pagure.io/koji/issue/4248
This commit is contained in:
parent
251a40facc
commit
3a4029a097
1 changed files with 20 additions and 8 deletions
|
|
@ -247,6 +247,7 @@ class ConfigFileTestCase(unittest.TestCase):
|
|||
if six.PY2:
|
||||
self.manager.scp_clz = mock.patch("ConfigParser.SafeConfigParser",
|
||||
spec=True).start()
|
||||
mock.patch('codecs.open').start()
|
||||
else:
|
||||
self.manager.cp_clz = mock.patch("configparser.ConfigParser",
|
||||
spec=True).start()
|
||||
|
|
@ -297,6 +298,10 @@ class ConfigFileTestCase(unittest.TestCase):
|
|||
self.assertTrue(isinstance(conf,
|
||||
six.moves.configparser.ConfigParser.__class__))
|
||||
self.real_parser_clz.assert_called_once()
|
||||
if six.PY2:
|
||||
self.real_parser_clz.return_value.read.assert_not_called()
|
||||
self.real_parser_clz.return_value.readfp.assert_called_once()
|
||||
else:
|
||||
self.real_parser_clz.return_value.read.assert_called_once_with([files], encoding='utf8')
|
||||
|
||||
# list as config_files
|
||||
|
|
@ -305,7 +310,11 @@ class ConfigFileTestCase(unittest.TestCase):
|
|||
koji.read_config_files(files)
|
||||
|
||||
self.real_parser_clz.assert_called_once()
|
||||
self.real_parser_clz.return_value.read.assert_called_once_with(files, encoding='utf8')
|
||||
if six.PY2:
|
||||
self.real_parser_clz.return_value.read.assert_not_called()
|
||||
self.real_parser_clz.return_value.readfp.assert_called()
|
||||
else:
|
||||
self.real_parser_clz.return_value.read.assert_called()
|
||||
|
||||
# tuple as config_files
|
||||
self.reset_mock()
|
||||
|
|
@ -364,6 +373,9 @@ class ConfigFileTestCase(unittest.TestCase):
|
|||
conf = koji.read_config_files(files)
|
||||
listdir_mock.assert_has_calls([call('gooddir'), call('emptydir')])
|
||||
self.real_parser_clz.assert_called_once()
|
||||
if six.PY2:
|
||||
self.real_parser_clz.return_value.readfp.assert_called()
|
||||
else:
|
||||
self.real_parser_clz.return_value.read.assert_called_once_with(
|
||||
['test1.conf',
|
||||
'gooddir/test1-1.conf',
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue