From 43a433d37a2e2e94f7aaba2cef679f0ab402e38d Mon Sep 17 00:00:00 2001 From: Yuming Zhu Date: Wed, 14 Mar 2018 20:09:01 +0800 Subject: [PATCH] do not shell=True --- koji/daemon.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/koji/daemon.py b/koji/daemon.py index bef06756..decee912 100644 --- a/koji/daemon.py +++ b/koji/daemon.py @@ -513,8 +513,7 @@ class SCM(object): if self.scmtype.startswith('GIT'): cmd = ['git', 'rev-parse', 'HEAD'] proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, - cwd=self.sourcedir, - shell=True) + cwd=self.sourcedir,) out, _ = proc.communicate() status = proc.wait() if status != 0: