particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR#4432: avoid loading system hub config in unit test

Browse source 
Merges #4432
https://pagure.io/koji/pull-request/4432

Fixes: #4431
https://pagure.io/koji/issue/4431
unit test reads system hub config
This commit is contained in:
Mike McLean 2025-08-01 15:12:43 -04:00
commit 5619342ef3
1 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/test_hub/test_client_session.py
View file

@ -1,8 +1,11 @@
import io import io
import mock import shutil
import tempfile
import time import time
import unittest import unittest
from unittest import mock
import koji import koji
from kojihub import kojixmlrpc, db from kojihub import kojixmlrpc, db
from koji.xmlrpcplus import Fault from koji.xmlrpcplus import Fault
@ -20,6 +23,7 @@ class FakeClient(koji.ClientSession):
def __init__(self, baseurl, opts=None, sinfo=None, auth_method=None): def __init__(self, baseurl, opts=None, sinfo=None, auth_method=None):
super(FakeClient, self).__init__(baseurl, opts=opts, sinfo=sinfo, auth_method=auth_method) super(FakeClient, self).__init__(baseurl, opts=opts, sinfo=sinfo, auth_method=auth_method)
self._test_hub_cfg = None
def new_session(self): def new_session(self):
self.rsession = FakeReqSession(self) self.rsession = FakeReqSession(self)
@ -56,6 +60,8 @@ class FakeReqSession:
environ['REMOTE_ADDR'] = '127.0.0.1' environ['REMOTE_ADDR'] = '127.0.0.1'
environ['REQUEST_METHOD'] = 'POST' environ['REQUEST_METHOD'] = 'POST'
environ['CONTENT_TYPE'] = 'text/xml' environ['CONTENT_TYPE'] = 'text/xml'
cfg = self.client_session._test_hub_cfg
environ['koji.hub.ConfigFile'] = cfg
for k in headers: for k in headers:
k2 = 'HTTP_' + k.upper().replace('-', '_') k2 = 'HTTP_' + k.upper().replace('-', '_')
@ -94,9 +100,17 @@ QP = db.QueryProcessor
class TestClientSession(unittest.TestCase): class TestClientSession(unittest.TestCase):
def setUp(self): def setUp(self):
self.tempdir = tempfile.mkdtemp()
self.context = mock.MagicMock() self.context = mock.MagicMock()
self.context.session.assertLogin = mock.MagicMock() self.context.session.assertLogin = mock.MagicMock()
# set up fake session
self.session = FakeClient('https://bad.server/') self.session = FakeClient('https://bad.server/')
cfg = '%s/hub.conf' % self.tempdir
with open(cfg, 'wt') as fp:
fp.write('[hub]\n#the end\n')
self.session._test_hub_cfg = cfg
self.QueryProcessor = mock.patch('kojihub.auth.QueryProcessor', self.QueryProcessor = mock.patch('kojihub.auth.QueryProcessor',
side_effect=self.getQuery).start() side_effect=self.getQuery).start()
self._dml = mock.patch('kojihub.db._dml').start() self._dml = mock.patch('kojihub.db._dml').start()
@ -108,6 +122,7 @@ class TestClientSession(unittest.TestCase):
def tearDown(self): def tearDown(self):
mock.patch.stopall() mock.patch.stopall()
shutil.rmtree(self.tempdir)
def getQuery(self, *args, **kwargs): def getQuery(self, *args, **kwargs):
query = QP(*args, **kwargs) query = QP(*args, **kwargs)