From 5a4efd6d07b98b288d26123a2b5836ad788ee13e Mon Sep 17 00:00:00 2001
From: Tomas Kopecek <tkopecek@redhat.com>
Date: Tue, 6 Oct 2020 15:08:57 +0200
Subject: [PATCH] fix merge problems

---
 setup.py         | 2 --
 tox.ini          | 4 ++++
 util/koji-gc     | 6 +++---
 util/koji-shadow | 1 -
 vm/kojivmd       | 4 ++--
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/setup.py b/setup.py
index b34c811d..987682fb 100644
--- a/setup.py
+++ b/setup.py
@@ -1,7 +1,5 @@
 from __future__ import absolute_import
 
-import sys
-
 from setuptools import setup
 
 
diff --git a/tox.ini b/tox.ini
index 81638095..c188442b 100644
--- a/tox.ini
+++ b/tox.ini
@@ -4,6 +4,10 @@ envlist = flake8,py2,py3
 [testenv:flake8]
 deps =
     flake8
+# On EL6, pip would get us a flake8 that doesn't work with python2.6. The next
+# two lines let us use an RPM-based version from EPEL if it is installed
+sitepackages = true
+whitelist_externals = flake8
 # These two lines just speed things up by avoiding unnecessary setup
 skip_install=true
 usedevelop=true
diff --git a/util/koji-gc b/util/koji-gc
index c14915d0..0c8af222 100755
--- a/util/koji-gc
+++ b/util/koji-gc
@@ -467,7 +467,7 @@ def handle_trash():
     mcall = koji.MultiCallSession(session, batch=1000)
     for binfo in continuing:
         mcall.buildReferences(binfo['id'], limit=10, lazy=True)
-    for binfo, [refs] in zip(continuing, mcall.call_all():
+    for binfo, [refs] in zip(continuing, mcall.call_all()):
         i += 1
         nvr = binfo['nvr']
         # XXX - this is more data than we need
@@ -651,7 +651,7 @@ def handle_delete(just_salvage=False):
     mcall = koji.MultiCallSession(session, batch=1000)
     for nvr, binfo in trash:
         mcall.listTags(build=binfo['id'], perms=False)
-    for (nvr, binfo), [tags] in zip(trash, mcall.call_all():
+    for (nvr, binfo), [tags] in zip(trash, mcall.call_all()):
         # see if build has been tagged elsewhere
         tags = [t['name'] for t in tags if t['name'] != trashcan_tag]
         if tags:
@@ -709,7 +709,7 @@ def handle_delete(just_salvage=False):
             mcall.untagBuildBypass(trashcan_tag, binfo['id'])
             mcall.deleteBuild(binfo['id'])
 
-    for binfo, result in zip(continuing, mcall.call_all():
+    for binfo, result in zip(continuing, mcall.call_all()):
         if isinstance(result, dict):
             print("Warning: deletion failed: %s" % result['faultString'])
             # TODO - log details for delete failures
diff --git a/util/koji-shadow b/util/koji-shadow
index 5c63185b..16bb2ab2 100755
--- a/util/koji-shadow
+++ b/util/koji-shadow
@@ -34,7 +34,6 @@ import string
 import sys
 import time
 import urllib2
-import xmlrpc.client  # for Fault
 
 import requests
 import rpm
diff --git a/vm/kojivmd b/vm/kojivmd
index 0c9f6e65..e50debd8 100755
--- a/vm/kojivmd
+++ b/vm/kojivmd
@@ -262,8 +262,8 @@ class DaemonXMLRPCServer(xmlrpc.server.SimpleXMLRPCServer):
                                                       logRequests=False)
         else:
             xmlrpc.server.SimpleXMLRPCServer.__init__(self, (addr, port),
-                                                     logRequests=False,
-                                                     allow_none=True)
+                                                      logRequests=False,
+                                                      allow_none=True)
         self.logger = logging.getLogger('koji.vm.DaemonXMLRPCServer')
         self.socket.settimeout(5)
         self.active = True