diff --git a/www/kojiweb/buildrootinfo.chtml b/www/kojiweb/buildrootinfo.chtml
index 4369ddc2..fc23f0b3 100644
--- a/www/kojiweb/buildrootinfo.chtml
+++ b/www/kojiweb/buildrootinfo.chtml
@@ -44,10 +44,10 @@
Repo Created | $util.formatTimeLong($buildroot.repo_create_event_time) |
- | Component RPMs |
+ Component RPMs |
- | Built RPMs |
+ Built RPMs |
diff --git a/www/kojiweb/builds.chtml b/www/kojiweb/builds.chtml
index 5d7b1a6f..88fa1504 100644
--- a/www/kojiweb/builds.chtml
+++ b/www/kojiweb/builds.chtml
@@ -66,11 +66,11 @@
|
#if $len($buildPages) > 1
-
@@ -118,11 +118,11 @@
|
#if $len($buildPages) > 1
-
diff --git a/www/kojiweb/buildsbystatus.chtml b/www/kojiweb/buildsbystatus.chtml
index a5a18f85..8a27dd01 100644
--- a/www/kojiweb/buildsbystatus.chtml
+++ b/www/kojiweb/buildsbystatus.chtml
@@ -4,7 +4,7 @@
#if not $label
#set $label = $value
#end if
-
+
#end def
#include "includes/header.chtml"
@@ -13,7 +13,7 @@
|
- |
| Succeeded |
-  |
+  |
$numSucceeded |
| Failed |
-  |
+  |
$numFailed |
| Canceled |
-  |
+  |
$numCanceled |
diff --git a/www/kojiweb/buildsbytarget.chtml b/www/kojiweb/buildsbytarget.chtml
index 3605dc40..e68cb5bb 100644
--- a/www/kojiweb/buildsbytarget.chtml
+++ b/www/kojiweb/buildsbytarget.chtml
@@ -4,7 +4,7 @@
#if not $label
#set $label = $value
#end if
-
+
#end def
#include "includes/header.chtml"
@@ -13,7 +13,7 @@
+
+
#include "includes/footer.chtml"
diff --git a/www/kojiweb/buildtargets.chtml b/www/kojiweb/buildtargets.chtml
index cb4041bc..395ca413 100644
--- a/www/kojiweb/buildtargets.chtml
+++ b/www/kojiweb/buildtargets.chtml
@@ -7,11 +7,11 @@
|
|
#if $len($targetPages) > 1
-
@@ -46,11 +46,11 @@
|
#if $len($targetPages) > 1
-
diff --git a/www/kojiweb/fileinfo.chtml b/www/kojiweb/fileinfo.chtml
index a7bb15bc..eadc570e 100644
--- a/www/kojiweb/fileinfo.chtml
+++ b/www/kojiweb/fileinfo.chtml
@@ -2,11 +2,11 @@
#import urllib
#include "includes/header.chtml"
- Information for file $file.name
+ Information for file $file.name
diff --git a/www/kojiweb/hosts.chtml b/www/kojiweb/hosts.chtml
index 53bfc9d9..3466cd6b 100644
--- a/www/kojiweb/hosts.chtml
+++ b/www/kojiweb/hosts.chtml
@@ -7,11 +7,11 @@
|
|
#if $len($hostPages) > 1
-
@@ -54,11 +54,11 @@
|
|
#if $len($hostPages) > 1
-
diff --git a/www/kojiweb/includes/header.chtml b/www/kojiweb/includes/header.chtml
index a0cada82..e000293a 100644
--- a/www/kojiweb/includes/header.chtml
+++ b/www/kojiweb/includes/header.chtml
@@ -1,7 +1,7 @@
#import koji
#import random
-
+
#def greeting()
#set $greetings = ('hello', 'hi', 'yo', "what's up", "g'day", 'back to work',
@@ -65,16 +65,16 @@
diff --git a/www/kojiweb/index.chtml b/www/kojiweb/index.chtml
index 9d4f7f31..409af01a 100644
--- a/www/kojiweb/index.chtml
+++ b/www/kojiweb/index.chtml
@@ -10,11 +10,11 @@
|
|
#if $len($buildPages) > 1
-
@@ -57,11 +57,11 @@
|
|
#if $len($taskPages) > 1
-
@@ -109,11 +109,11 @@
|
|
#if $len($packagePages) > 1
-
diff --git a/www/kojiweb/index.py b/www/kojiweb/index.py
index 9b990224..984d0ddd 100644
--- a/www/kojiweb/index.py
+++ b/www/kojiweb/index.py
@@ -4,6 +4,7 @@ import re
import sys
import mod_python
import mod_python.Cookie
+import Cheetah.Filters
import Cheetah.Template
import datetime
import time
@@ -85,6 +86,16 @@ def _initValues(req, title='Build System Info', pageID='summary'):
return values
+# Escape ampersands so the output can be valid XHTML
+class XHTMLFilter(Cheetah.Filters.EncodeUnicode):
+ def filter(self, *args, **kw):
+ result = super(XHTMLFilter, self).filter(*args, **kw)
+ result = result.replace('&', '&')
+ result = result.replace(' ', ' ')
+ result = result.replace('<', '<')
+ result = result.replace('>', '>')
+ return result
+
def _genHTML(req, fileName):
os.chdir(os.path.dirname(req.filename))
@@ -93,7 +104,7 @@ def _genHTML(req, fileName):
else:
req._values['currentUser'] = None
- return Cheetah.Template.Template(file=fileName, searchList=[req._values], filter='EncodeUnicode').respond()
+ return Cheetah.Template.Template(file=fileName, searchList=[req._values], filter=XHTMLFilter).respond()
def _getServer(req):
serverURL = req.get_options().get('KojiHubURL', 'http://localhost/kojihub')
diff --git a/www/kojiweb/notificationedit.chtml b/www/kojiweb/notificationedit.chtml
index ac066e24..9907ea29 100644
--- a/www/kojiweb/notificationedit.chtml
+++ b/www/kojiweb/notificationedit.chtml
@@ -17,9 +17,9 @@
| Package |
|
@@ -28,16 +28,16 @@
Tag |
|
| Success Only? |
-
+ | |
|
diff --git a/www/kojiweb/packageinfo.chtml b/www/kojiweb/packageinfo.chtml
index 7ae06bd9..e0fcb716 100644
--- a/www/kojiweb/packageinfo.chtml
+++ b/www/kojiweb/packageinfo.chtml
@@ -20,11 +20,11 @@
|
|
#if $len($buildPages) > 1
-
@@ -68,11 +68,11 @@
|
|
#if $len($tagPages) > 1
-
diff --git a/www/kojiweb/packages.chtml b/www/kojiweb/packages.chtml
index 9f79fee9..836cdca9 100644
--- a/www/kojiweb/packages.chtml
+++ b/www/kojiweb/packages.chtml
@@ -36,11 +36,11 @@
|
|
#if $len($packagePages) > 1
-
@@ -85,11 +85,11 @@
|
|
#if $len($packagePages) > 1
-
diff --git a/www/kojiweb/packagesbyuser.chtml b/www/kojiweb/packagesbyuser.chtml
index ec6241d4..f32de512 100644
--- a/www/kojiweb/packagesbyuser.chtml
+++ b/www/kojiweb/packagesbyuser.chtml
@@ -7,11 +7,11 @@
|
|
#if $len($userPages) > 1
-
@@ -36,7 +36,7 @@
#for $user in $users
|
| $user.name |
-  |
+  |
$user.packages |
#end for
@@ -48,11 +48,11 @@
#if $len($userPages) > 1
-
diff --git a/www/kojiweb/rpminfo.chtml b/www/kojiweb/rpminfo.chtml
index 896ccd61..7a3390b5 100644
--- a/www/kojiweb/rpminfo.chtml
+++ b/www/kojiweb/rpminfo.chtml
@@ -46,7 +46,7 @@
#for $dep in $provides
- | $util.formatDep($dep.name, $dep.version, $dep.flags) |
+ $util.escapeHTML($util.formatDep($dep.name, $dep.version, $dep.flags)) |
#end for
@@ -62,7 +62,7 @@
#for $dep in $requires
- | $util.formatDep($dep.name, $dep.version, $dep.flags) |
+ $util.escapeHTML($util.formatDep($dep.name, $dep.version, $dep.flags)) |
#end for
@@ -78,7 +78,7 @@
#for $dep in $obsoletes
- | $util.formatDep($dep.name, $dep.version, $dep.flags) |
+ $util.escapeHTML($util.formatDep($dep.name, $dep.version, $dep.flags)) |
#end for
@@ -94,7 +94,7 @@
#for $dep in $conflicts
- | $util.formatDep($dep.name, $dep.version, $dep.flags) |
+ $util.escapeHTML($util.formatDep($dep.name, $dep.version, $dep.flags)) |
#end for
@@ -111,11 +111,11 @@
|
|
#if $len($filePages) > 1
-
@@ -135,7 +135,7 @@
|
#for $file in $files
- | $file.name | $file.size |
+ $file.name | $file.size |
#end for
diff --git a/www/kojiweb/rpmlist.chtml b/www/kojiweb/rpmlist.chtml
index 76493658..26b18e76 100644
--- a/www/kojiweb/rpmlist.chtml
+++ b/www/kojiweb/rpmlist.chtml
@@ -12,11 +12,11 @@
|
#if $len($rpmPages) > 1
-
@@ -57,11 +57,11 @@
|
|
#if $len($rpmPages) > 1
-
diff --git a/www/kojiweb/rpmsbyhost.chtml b/www/kojiweb/rpmsbyhost.chtml
index c3018130..5503a826 100644
--- a/www/kojiweb/rpmsbyhost.chtml
+++ b/www/kojiweb/rpmsbyhost.chtml
@@ -39,11 +39,11 @@
|
|
#if $len($hostPages) > 1
-
@@ -68,7 +68,7 @@
#for $host in $hosts
|
| $host.name |
-  |
+  |
$host.rpms |
#end for
@@ -80,11 +80,11 @@
|
#if $len($hostPages) > 1
-
diff --git a/www/kojiweb/searchresults.chtml b/www/kojiweb/searchresults.chtml
index df3b40c0..c0c21b5b 100644
--- a/www/kojiweb/searchresults.chtml
+++ b/www/kojiweb/searchresults.chtml
@@ -9,11 +9,11 @@
|
|
#if $len($resultPages) > 1
-
@@ -50,11 +50,11 @@
|
|
#if $len($resultPages) > 1
-
diff --git a/www/kojiweb/tagedit.chtml b/www/kojiweb/tagedit.chtml
index e78bc0e6..242bdd6b 100644
--- a/www/kojiweb/tagedit.chtml
+++ b/www/kojiweb/tagedit.chtml
@@ -25,13 +25,13 @@
|
| Locked |
-
+ | |
| Permission |
|