particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Less log noise for empty or invalid requests

Browse source
This commit is contained in:
Mike McLean 2025-04-09 10:06:26 -04:00 • committed by Tomas Kopecek
parent c44a33ceb6
commit 733294c87d
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
kojihub/kojixmlrpc.py
View file

@ -239,6 +239,11 @@ class ModXMLRPCRequestHandler(object):
if maxlen and rlen > maxlen:
raise koji.GenericError('Request too long')
parser.feed(chunk)
if rlen == 0:
# blank posts are unfortunately a common client mistake
# make them less noisy
self.logger.debug('Empty request')
raise BadRequest('Empty request')
parser.close()
return unmarshaller.close(), unmarshaller.getmethodname()
@ -296,7 +301,12 @@ class ModXMLRPCRequestHandler(object):
return kojihub.handle_upload(environ)
def handle_rpc(self, environ):
params, method = self._read_request(environ['wsgi.input'])
try:
params, method = self._read_request(environ['wsgi.input'])
except Exception as e:
# only log full trace in debug stream
self.logger.debug("Error reading request", exc_info=True)
raise BadRequest('Invalid request: %s' % e)
return self._dispatch(method, params)
def check_session(self):