particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hub: fix KeyError in get_notification_recipients

Browse source
This commit is contained in:
Yuming Zhu 2018-02-08 13:18:58 +08:00 • committed by Mike McLean
parent 29aeb5f0a7
commit 77af6d6688
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hub/kojihub.py
View file

@ -7153,7 +7153,7 @@ def get_notification_recipients(build, tag_id, state):
users_usertypes = [koji.USERTYPES['NORMAL'], koji.USERTYPES['GROUP']]
clauses = [
'status = %(users_status)i',
'usertype IN %(users_usertype)s',
'usertype IN %(users_usertypes)s',
]
if not build and tag_id:

6
tests/test_hub/test_notifications.py
View file

@ -71,7 +71,7 @@ class TestNotifications(unittest.TestCase):
self.assertEqual(q.columns, ('email',))
self.assertEqual(q.tables, ['build_notifications'])
self.assertEqual(q.clauses, [ 'status = %(users_status)i',
'usertype IN %(users_usertype)s',
'usertype IN %(users_usertypes)s',
'package_id IS NULL',
'tag_id IS NULL',
'success_only = FALSE'])
@ -95,7 +95,7 @@ class TestNotifications(unittest.TestCase):
self.assertEqual(q.columns, ('email',))
self.assertEqual(q.tables, ['build_notifications'])
self.assertEqual(q.clauses, ['status = %(users_status)i',
'usertype IN %(users_usertype)s',
'usertype IN %(users_usertypes)s',
'package_id = %(package_id)i OR package_id IS NULL',
'tag_id IS NULL',
'success_only = FALSE'])
@ -139,7 +139,7 @@ class TestNotifications(unittest.TestCase):
self.assertEqual(q.columns, ('email',))
self.assertEqual(q.tables, ['build_notifications'])
self.assertEqual(q.clauses, ['status = %(users_status)i',
'usertype IN %(users_usertype)s',
'usertype IN %(users_usertypes)s',
'package_id = %(package_id)i OR package_id IS NULL',
'tag_id = %(tag_id)i OR tag_id IS NULL',
'success_only = FALSE'])