Don't try to resolve server version for old hubs

Related: https://pagure.io/koji/issue/3890
This commit is contained in:
Tomas Kopecek 2023-09-05 12:38:58 +02:00
parent d43ad529c1
commit 7a9b0561eb
7 changed files with 69 additions and 21 deletions

View file

@ -60,7 +60,7 @@ class TestAddChannel(utils.CliTestCase):
expected_api = 'Invalid method: addChannel'
expected = 'addChannel is available on hub from Koji 1.26 version, your version ' \
'is 1.25.1\n'
self.session.getKojiVersion.return_value = '1.25.1'
self.session.hub_version_str = '1.25.1'
self.session.addChannel.side_effect = koji.GenericError(expected_api)
arguments = ['--description', self.description, self.channel_name]

View file

@ -32,7 +32,8 @@ class TestCancel(utils.CliTestCase):
%s: error: {message}
""" % (self.progname, self.progname)
self.session.getKojiVersion.return_value = '1.33.0'
self.session.hub_version = (1, 33, 0)
self.session.hub_version_str = '1.33.0'
def test_anon_cancel(self):
args = ['123']
@ -154,7 +155,7 @@ No such build: '%s'
self.session.cancelBuild.assert_called_once_with(args[1], strict=True)
def test_non_exist_build_and_task_older_hub(self):
self.session.getKojiVersion.return_value = '1.32.0'
self.session.hub_version = (1, 32, 0)
args = ['11111', 'nvr-1-30.1']
expected_warn = """No such task: %s
""" % (args[0])

View file

@ -78,7 +78,7 @@ Options:
expected_api = 'Invalid method: editChannel'
expected = 'editChannel is available on hub from Koji 1.26 version, your version ' \
'is 1.25.1\n'
self.session.getKojiVersion.return_value = '1.25.1'
self.session.hub_version_str = '1.25.1'
self.session.editChannel.side_effect = koji.GenericError(expected_api)
self.assert_system_exit(
@ -94,7 +94,6 @@ Options:
self.session.editChannel.assert_called_once_with(self.channel_old, name=self.channel_new,
description=self.description)
self.session.getChannel.assert_called_once_with(self.channel_old)
self.session.getKojiVersion.assert_called_once_with()
def test_handle_edit_channel_non_exist_channel(self):
expected = 'No such channel: %s\n' % self.channel_old