particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

promoteBuild: reformat error messages

Browse source
This commit is contained in:
Yu Ming Zhu 2023-12-14 18:43:53 +00:00
parent 3dbe136187
commit 8a64c93d05
2 changed files with 15 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/test_hub/test_promote_build.py
View file

@ -113,7 +113,10 @@ class TestPromoteBuild(unittest.TestCase):
with self.assertRaises(koji.GenericError) as cm:
self.exports.promoteBuild('a-regular-build')
self.assertEqual(str(cm.exception), "Not a draft build: testnvr")
self.assertEqual(
str(cm.exception),
"Cannot promote build testnvr. Reason: Not a draft build"
)
self.assertEqual(len(self.updates), 0)
def test_promote_build_target_release(self):
@ -123,6 +126,7 @@ class TestPromoteBuild(unittest.TestCase):
'version': 'bar',
# bad delimiter
'release': 'tgtrel@draft_1',
'nvr': 'testnvr',
'extra': {
'draft': {
'promoted': False,
@ -171,7 +175,7 @@ class TestPromoteBuild(unittest.TestCase):
self.exports.promoteBuild('a-regular-build')
self.assertEqual(
str(cm.exception),
f"Cannot promote build - {draft['nvr']}. Reason: state (BUILDING) is not COMPLETE."
f"Cannot promote build {draft['nvr']}. Reason: state (BUILDING) is not COMPLETE."
)
self.assertEqual(len(self.updates), 0)
@ -186,11 +190,11 @@ class TestPromoteBuild(unittest.TestCase):
self.exports.promoteBuild('a-regular-build')
self.assertEqual(
str(cm.exception),
"Cannot promote to an existing target build: oldnvr(#any)"
"Cannot promote build testnvr. Reason: Target build exists: oldnvr(#any)"
)
self.assertEqual(len(self.updates), 0)
self.get_build.assert_called_with({
'name': 'foo',
'version': 'bar',
'release': 'tgtrel'
})
}, strict=False)