From 8ba268eecc473b0e6744e16c9f297db89a7a92ea Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Mon, 11 Aug 2025 17:20:43 -0400 Subject: [PATCH] tweak unit test --- tests/test_hub/test_add_rpm_sig.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/test_hub/test_add_rpm_sig.py b/tests/test_hub/test_add_rpm_sig.py index 3505d3d4..fcf62b0d 100644 --- a/tests/test_hub/test_add_rpm_sig.py +++ b/tests/test_hub/test_add_rpm_sig.py @@ -146,15 +146,22 @@ class TestAddRPMSig(unittest.TestCase): def test_add_rpm_sig_bad_sigkey(self): """bad sigkey failure case""" sighdr = 'SIG HEADER 99' - self.isdir.side_effect = [True] - self.get_rpm.side_effect = [{'build_id': 100, 'external_repo_id': None}] + self.isdir.return_value = True + self.get_rpm.return_value = {'build_id': 100, 'external_repo_id': None} - with self.assertRaises(koji.GenericError): - kojihub.add_rpm_sig(1, sighdr, sigkey='foo/bar !') + badkeys = [ + 'white space', + 'badchar!', + '.hidden', + 'sub/dir', + ] + for sigkey in badkeys: + with self.assertRaises(koji.GenericError): + kojihub.add_rpm_sig(1, sighdr, sigkey=sigkey) self.assertEqual(len(self.inserts), 0) self.open.assert_not_called() - self.isdir.assert_called_once() + self.isdir.assert_called() class TestScanHeaderOnly(unittest.TestCase):