particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib: better argument checking for eventFromOpts

Browse source 
Fixes: https://pagure.io/koji/issue/2513
This commit is contained in:
Tomas Kopecek 2020-10-01 15:08:28 +02:00
parent 362a216448
commit 8ff5759b21
2 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/test_lib/test_utils.py
View file

@ -1121,11 +1121,11 @@ class MavenUtilTestCase(unittest.TestCase):
self.assertEqual(None, koji.util.eventFromOpts(session, opts))
# opts.ts = timestamp
opts = mock.MagicMock(event='', ts=timestamp)
opts = mock.MagicMock(event=None, ts=timestamp)
self.assertEqual(event, koji.util.eventFromOpts(session, opts))
# opts.repo = '1'
opts = mock.MagicMock(event='', ts='', repo=1)
opts = mock.MagicMock(event=None, ts=None, repo=1)
expect = {'id': repo_info['create_event'],
'ts': repo_info['create_ts']}
@ -1134,9 +1134,13 @@ class MavenUtilTestCase(unittest.TestCase):
six.assertCountEqual(self, list(expect.items()), list(actual.items()))
# no event is matched case
opts = mock.MagicMock(event=0, ts=0, repo=0)
opts = mock.MagicMock(event=None, ts=None, repo=None)
self.assertEqual(None, koji.util.eventFromOpts(session, opts))
# special case for ts 0
opts = mock.MagicMock(event=None, ts=0, repo=None)
self.assertEqual(event, koji.util.eventFromOpts(session, opts))
def test_setup_rlimits(self):
"""Test test_setup_rlimits function"""
logger = mock.MagicMock()